Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 569966 - check-reqs.eclass: please allow to optionally use swap for memory checks
Summary: check-reqs.eclass: please allow to optionally use swap for memory checks
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Quality Assurance Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-28 12:32 UTC by Andrew Savchenko
Modified: 2019-08-20 07:30 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch (check-reqs.eclass.patch,2.27 KB, patch)
2019-05-13 14:36 UTC, Arfrever Frehtes Taifersar Arahesis
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Savchenko gentoo-dev 2015-12-28 12:32:52 UTC
Hello,

it would be useful to allow users to include swap space for memory
estimation. Sometimes this is the only way to build package without
cross-compiling. So I propose something like:

CHECKREQS_MEMORY_USE_SWAP="yes|no"

which can be set on command line, in make.conf or in per-package env
setup.

This option should be disabled by default, of course.
Comment 1 Ian Guerit 2016-04-11 19:42:43 UTC
Similar issue with bug #579658 where would be useful to skip CHECKREQS_MEMORY
Comment 2 Arfrever Frehtes Taifersar Arahesis 2019-05-13 14:36:12 UTC
Created attachment 576460 [details, diff]
Patch

This patch checks for swap unconditionally.
If usage of swap appears to be needed, then a warning is printed.
Comment 3 Larry the Git Cow gentoo-dev 2019-08-19 20:35:39 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=297e41122a17dea6e7867ed4345255916c379a6c

commit 297e41122a17dea6e7867ed4345255916c379a6c
Author:     Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
AuthorDate: 2019-05-13 14:30:15 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2019-08-19 20:27:36 +0000

    check-reqs.eclass: check-reqs_memory(): Check for available swap.
    
    Print warning if usage of swap appears to be needed.
    
    Closes: https://bugs.gentoo.org/569966
    Signed-off-by: Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 eclass/check-reqs.eclass | 25 ++++++++++++++++++-------
 1 file changed, 18 insertions(+), 7 deletions(-)