Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 568398 - <dev-util/nsis-2.51: privilege escalation and code execution vulnerabilities in generated NSIS installers
Summary: <dev-util/nsis-2.51: privilege escalation and code execution vulnerabilities ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Security
Classification: Unclassified
Component: Vulnerabilities (show other bugs)
Hardware: All Linux
: Normal major (vote)
Assignee: Gentoo Security
URL: https://bugzilla.redhat.com/show_bug....
Whiteboard: ~1 [noglsa]
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-16 08:24 UTC by Agostino Sarubbo
Modified: 2016-06-30 11:42 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2015-12-16 08:24:37 UTC
From ${URL} :

Installers generated by NSIS 2.46 are vulnerable to attacks that can lead to code execution and 
privilege escalation (if the installer is running with elevated privileges).

Debian's bug report:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=806036

Upstream bug:

http://sourceforge.net/p/nsis/bugs/1125/


@maintainer(s): after the bump, in case we need to stabilize the package, please let us know if it is ready for the stabilization or not.
Comment 1 Gordon Pettey 2016-06-06 01:52:02 UTC
Upstream bug 1125 was marked fixed in 2.50 2016-12-26.
Comment 2 Alon Bar-Lev (RETIRED) gentoo-dev 2016-06-12 11:46:48 UTC
nsis-2.51 is in tree.
Comment 3 Alon Bar-Lev (RETIRED) gentoo-dev 2016-06-12 11:47:45 UTC
Oh... sorry this is a security one.
We should remove stable keyword from nsis and in few weeks cleanup old ebuilds.
Comment 4 Aaron Bauman (RETIRED) gentoo-dev 2016-06-13 11:05:34 UTC
(In reply to Alon Bar-Lev from comment #3)
> Oh... sorry this is a security one.
> We should remove stable keyword from nsis and in few weeks cleanup old
> ebuilds.

The usual process is immediate stabilization unless the maintainer dictates otherwise.  Such as a major code refactor etc.  As there is no maintainer, we will call for stabilization.

@arches, please stabilize:

=dev-util/nsis-2.51
Comment 5 Agostino Sarubbo gentoo-dev 2016-06-13 12:30:11 UTC
@alonbl:

the instructions to have a valid mingw env, as stated in the ebuild, fails for me.

>(chroot) vh ~ # USE='cxx' crossdev --stable --libc '[latest]' -t i686-w64-mingw32
> * You need to specify an output overlay.  Please use --ov-output, or consult
> * https://wiki.gentoo.org/wiki/Overlay/Local_overlay for more details.

Do we need to update them or there is something wrong on my side?
Comment 6 Alon Bar-Lev (RETIRED) gentoo-dev 2016-06-13 13:16:13 UTC
Hi!
Before we proceed, can we just drop stable keyword from this package?
Thanks!
Comment 7 Kristian Fiskerstrand (RETIRED) gentoo-dev 2016-06-13 13:25:44 UTC
(In reply to Alon Bar-Lev from comment #6)
> Hi!
> Before we proceed, can we just drop stable keyword from this package?
> Thanks!

As far as I can see there are no packages depending on it, but it will require a removal GLSA as it lose formal security tracking support.
Comment 8 Alon Bar-Lev (RETIRED) gentoo-dev 2016-06-13 16:00:56 UTC
(In reply to Kristian Fiskerstrand from comment #7)
> (In reply to Alon Bar-Lev from comment #6)
> > Hi!
> > Before we proceed, can we just drop stable keyword from this package?
> > Thanks!
> 
> As far as I can see there are no packages depending on it, but it will
> require a removal GLSA as it lose formal security tracking support.

So can I just remove the old ebuild?
Comment 9 SpanKY gentoo-dev 2016-06-13 18:29:50 UTC
(In reply to Alon Bar-Lev from comment #8)

go for it
Comment 10 Alon Bar-Lev (RETIRED) gentoo-dev 2016-06-13 19:02:37 UTC
Removed.
Comment 11 Agostino Sarubbo gentoo-dev 2016-06-14 06:48:23 UTC
(In reply to Alon Bar-Lev from comment #10)
> Removed.

so does it needs stabilization or you prefer that it remanins ~arch ?
Comment 12 Alon Bar-Lev (RETIRED) gentoo-dev 2016-06-14 06:51:27 UTC
(In reply to Agostino Sarubbo from comment #11)
> (In reply to Alon Bar-Lev from comment #10)
> > Removed.
> 
> so does it needs stabilization or you prefer that it remanins ~arch ?

yes, there was no reason to make it stable, it is to fragile anyway. the requirement of having a cross compiler installed is sufficient to reject from stable.
Comment 13 Aaron Bauman (RETIRED) gentoo-dev 2016-06-14 08:04:50 UTC
Stable package removed and fixed unstable package is in tree.  

@security, please vote on the removal GLSA.
Comment 14 Aaron Bauman (RETIRED) gentoo-dev 2016-06-30 11:42:25 UTC
Changing to unstable as the package was never intended for the stable branch.