567674 – net-wireless/crda: Patch for (yet another) missing include

Bug 567674 - net-wireless/crda: Patch for (yet another) missing include

Summary: net-wireless/crda: Patch for (yet another) missing include

Status:	RESOLVED OBSOLETE

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Hardened (show other bugs)
Hardware:	All Linux

Importance:	Normal trivial (vote)
Assignee:	Gentoo musl team

URL:
Whiteboard:
Keywords:	PATCH

Depends on:
Blocks:	musl-porting
	Show dependency tree

Reported:	2015-12-06 19:48 UTC by Damien Levac
Modified:	2021-12-02 04:20 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Patch that add `#include <linux/limits.h>` to reglib.h (crda-1.1.3-pathmax-undeclared.patch,253 bytes, patch) 2015-12-06 19:48 UTC, Damien Levac	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Damien Levac 2015-12-06 19:48:41 UTC

Created attachment 418678 [details, diff]
Patch that add `#include <linux/limits.h>` to reglib.h

When trying to emerge crda-1.1.3 with musl, the build fails because reglib.h does not include <linux/limits.h> even though it makes use of PATH_MAX. I have included a patch that fixes the problem.

Comment 1 Felix Janda 2015-12-06 22:56:11 UTC

Please use the POSIX header <limits.h> if it is just for PATH_MAX.
Also, PATH_MAX is not used in reglib.h and would therefore better fit
into reglib.c.

I think it is indirectly fixed in upstream commit
f4c3e3fcae69d90ad3763d2602765104dcb04708. Does version 3.18 work for
you?

Comment 2 Sam James archtester

2021-12-02 04:20:34 UTC

4.14 built fine here.