Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 567288 - net-misc/wget-1.17[-ssl]: build fails: ftp.c:396:7: error: 'using_data_security' undeclared
Summary: net-misc/wget-1.17[-ssl]: build fails: ftp.c:396:7: error: 'using_data_securi...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL: http://lists.gnu.org/archive/html/bug...
Whiteboard:
Keywords: UPSTREAM
Depends on:
Blocks:
 
Reported: 2015-12-01 22:15 UTC by Joshua Kinard
Modified: 2015-12-12 21:04 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Kinard gentoo-dev 2015-12-01 22:15:49 UTC
Discovered this during a MIPS catalyst stage1 run, reproduced on amd64 as well.  If USE="-ssl", which passes --without-ssl to ./configure, then wget's compiliation will fail due to several SSL variables getting evaluated outside of #ifdef HAVE_SSL clauses.  This bug has been reported upstream and there is a short discussion on the wget mailing list about it, but it is yet unresolved.  Creating this bug for tracking purposes.

Errors:

MIPS:

mips64-unknown-linux-gnu-gcc -DHAVE_CONFIG_H -DSYSTEM_WGETRC=\"/etc/wgetrc\" -DLOCALEDIR=\"/usr/share/locale\" -I.  -I../lib -I../lib   -DNDEBUG -O2 -pipe -march=r12
k -mtune=r12k -mno-fix-r10000 -mabi=n32 -mplt -fomit-frame-pointer -fforce-addr -fivopts -fmodulo-sched -ftree-vectorize -c -o ftp.o ftp.c
In file included from ftp.c:32:0:
wget.h:51:0: warning: "NDEBUG" redefined
 # define NDEBUG
 ^
<command-line>:0:0: note: this is the location of the previous definition
ftp.c: In function 'getftp':
ftp.c:396:7: error: 'using_data_security' undeclared (first use in this function)
       using_data_security = con->st & DATA_CHANNEL_SECURITY;
       ^
ftp.c:396:7: note: each undeclared identifier is reported only once for each function it appears in
mips64-unknown-linux-gnu-gcc -DHAVE_CONFIG_H -DSYSTEM_WGETRC=\"/etc/wgetrc\" -DLOCALEDIR=\"/usr/share/locale\" -I.  -I../lib -I../lib   -DNDEBUG -O2 -pipe -march=r12k -mtune=r12k -mno-fix-r10000 -mabi=n32 -mplt -fomit-frame-pointer -fforce-addr -fivopts -fmodulo-sched -ftree-vectorize -c -o css_.o css_.c
Makefile:1577: recipe for target 'ftp.o' failed
make[3]: *** [ftp.o] Error 1
make[3]: *** Waiting for unfinished jobs....
In file included from css_.c:1:0:
wget.h:51:0: warning: "NDEBUG" redefined
 # define NDEBUG
 ^
<command-line>:0:0: note: this is the location of the previous definition
make[3]: Leaving directory '/var/tmp/portage/net-misc/wget-1.17/work/wget-1.17/src'
Makefile:1392: recipe for target 'all' failed
make[2]: *** [all] Error 2
make[2]: Leaving directory '/var/tmp/portage/net-misc/wget-1.17/work/wget-1.17/src'
Makefile:1399: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/var/tmp/portage/net-misc/wget-1.17/work/wget-1.17'
Makefile:1355: recipe for target 'all' failed
make: *** [all] Error 2
 * ERROR: net-misc/wget-1.17::gentoo failed (compile phase):
 *   emake failed


AMD64:

main.c: In function 'main':
main.c:1845:72: error: 'SCHEME_FTPS' undeclared (first use in this function)
               && ((url_scheme (*t) != SCHEME_FTP && url_scheme (*t) != SCHEME_FTPS)
                                                                        ^
main.c:1845:72: note: each undeclared identifier is reported only once for each function it appears in
Makefile:1577: recipe for target 'main.o' failed
make[3]: *** [main.o] Error 1
recur.c: In function 'download_child':
recur.c:613:73: error: 'SCHEME_FTPS' undeclared (first use in this function)
   if (!u_scheme_like_http && !((u->scheme == SCHEME_FTP || u->scheme == SCHEME_FTPS) && opt.follow_ftp))
                                                                         ^
recur.c:613:73: note: each undeclared identifier is reported only once for each function it appears in
Makefile:1577: recipe for target 'recur.o' failed
make[3]: *** [recur.o] Error 1
retr.c: In function 'retrieve_url':
retr.c:840:87: error: 'SCHEME_FTPS' undeclared (first use in this function)
       if (redirection_count && local_file && (u->scheme == SCHEME_FTP || u->scheme == SCHEME_FTPS))
                                                                                       ^
retr.c:840:87: note: each undeclared identifier is reported only once for each function it appears in
retr.c: In function 'retrieve_from_file':
retr.c:1102:78: error: 'SCHEME_FTPS' undeclared (first use in this function)
           && ((cur_url->url->scheme != SCHEME_FTP && cur_url->url->scheme != SCHEME_FTPS) || proxy))
Comment 1 Joshua Kinard gentoo-dev 2015-12-01 22:17:04 UTC
Upstream bug URL (our 'See Also' field does not recognize Savannah as a bug tracker):
http://savannah.gnu.org/bugs/?46537
Comment 2 SpanKY gentoo-dev 2015-12-03 02:16:05 UTC
i'm fine with the patch you linked to on the upstream mailing list.  feel free to add it the current 1.17 ebuild.
Comment 3 Joshua Kinard gentoo-dev 2015-12-05 22:04:27 UTC
(In reply to SpanKY from comment #2)
> i'm fine with the patch you linked to on the upstream mailing list.  feel
> free to add it the current 1.17 ebuild.

Looks like they fixed and closed the bug, but aren't issuing a minor version bump or anything yet over this issue.  I'll add these three patches to the existing 1.17 ebuild, w/o a rev bump since they're build-time fixes:

http://git.savannah.gnu.org/cgit/wget.git/patch/?id=ad5a28352883f661f390ff320fb2130cc6a6d443
http://git.savannah.gnu.org/cgit/wget.git/patch/?id=8977e6323968318c5b3112133971f694d2d0ef24
http://git.savannah.gnu.org/cgit/wget.git/patch/?id=ca0c272eae7dbceef07a52de43e399e297072933

Only question is, one of the 1.17 patches is up on the distfiles mirror instead of in $FILESDIR.  It's only a 4.2K patch; is this something new?  I am planning to add the three new patches to $FILESDIR, unless you want them all to go into distfiles (and if so, might be better to create a patchball instead of four discrete patch files).
Comment 4 SpanKY gentoo-dev 2015-12-09 22:26:52 UTC
they're talking about pushing a 1.17.1 release soon that should include these fixes.  so i guess that makes the question moot :).
Comment 5 SpanKY gentoo-dev 2015-12-12 21:04:36 UTC
1.17.1 is in the tree now and should include these fixes.  please re-open if things still fail though.

http://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e98b427cf0643b5a5b62ba000a762808a9d51ce1