Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 567080 - net-p2p/litecoin-qt failing to build with upnp USE flag enabled due to >=net-libs/miniupnpc-1.9
Summary: net-p2p/litecoin-qt failing to build with upnp USE flag enabled due to >=net-...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Anthony Basile
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-29 07:10 UTC by Oleh
Modified: 2015-12-16 17:36 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,41.24 KB, text/x-log)
2015-11-29 07:10 UTC, Oleh
Details
patch (litecoin-qt-0.10.2.2-miniupnpc.patch,701 bytes, patch)
2015-12-16 12:59 UTC, Oleh
Details | Diff
updated ebuild (litecoin-qt-0.10.2.2-r2.ebuild,3.22 KB, text/plain)
2015-12-16 12:59 UTC, Oleh
Details
ebuild diff (ebuild.diff,420 bytes, patch)
2015-12-16 13:02 UTC, Oleh
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oleh 2015-11-29 07:10:13 UTC
Exactly same problem observed with bitcoin-qt:
https://bugs.gentoo.org/show_bug.cgi?id=563462

Reproducible: Always

Steps to Reproduce:
1. emerge litecoin-qt, assuming >=net-libs/miniupnpc-1.9 installed
2. notice a build faiure
3. downgrade net-libs/miniupnpc, notice a successful build.
Actual Results:  
protector-all -fPIE -fvisibility=hidden -c -o libbitcoin_server_a-rpcblockchain.o `test -f 'rpcblockchain.cpp' || echo './'`rpcblockchain.cpp
[01m[Knet.cpp:[m[K In function ‘[01m[Kvoid ThreadMapPort()[m[K’:
[01m[Knet.cpp:1026:74:[m[K [01;31m[Kerror: [m[Kinvalid conversion from ‘[01m[Kint*[m[K’ to ‘[01m[Kunsigned char[m[K’ [-fpermissive]
     devlist = upnpDiscover(2000, multicastif, minissdpdpath, 0, 0, &error);
[01;32m[K                                                                          ^[m[K
[01m[Knet.cpp:1026:74:[m[K [01;31m[Kerror: [m[Ktoo few arguments to function ‘[01m[KUPNPDev* upnpDiscover(int, const char*, const char*, int, int, unsigned char, int*)[m[K’
In file included from [01m[Knet.cpp:25:0[m[K:
[01m[K/usr/include/miniupnpc/miniupnpc.h:62:1:[m[K [01;36m[Knote: [m[Kdeclared here
 upnpDiscover(int delay, const char * multicastif,
[01;32m[K ^[m[K
Makefile:3572: recipe for target 'libbitcoin_server_a-net.o' failed
make[2]: *** [libbitcoin_server_a-net.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/var/tmp/portage/net-p2p/litecoin-qt-0.10.2.2-r1/work/litecoin-0.10.2.2/src'
Makefile:6280: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/var/tmp/portage/net-p2p/litecoin-qt-0.10.2.2-r1/work/litecoin-0.10.2.2/src'
Makefile:568: recipe for target 'all-recursive' failed
make: *** [all-recursive] Error 1
 * ERROR: net-p2p/litecoin-qt-0.10.2.2-r1::gentoo failed (compile phase):
 *   emake failed
 * 
 * If you need support, post the output of `emerge --info '=net-p2p/litecoin-qt-0.10.2.2-r1::gentoo'`,
 * the complete build log and the output of `emerge -pqv '=net-p2p/litecoin-qt-0.10.2.2-r1::gentoo'`.
 * The complete build log is located at '/var/tmp/portage/net-p2p/litecoin-qt-0.10.2.2-r1/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/net-p2p/litecoin-qt-0.10.2.2-r1/temp/environment'.
 * Working directory: '/var/tmp/portage/net-p2p/litecoin-qt-0.10.2.2-r1/work/litecoin-0.10.2.2'
 * S: '/var/tmp/portage/net-p2p/litecoin-qt-0.10.2.2-r1/work/litecoin-0.10.2.2'
Comment 1 Oleh 2015-11-29 07:10:31 UTC
Created attachment 418116 [details]
build.log
Comment 2 Oleh 2015-12-09 17:22:08 UTC
any progress on this? the fix is about the same like in bitcoin-qt
Comment 3 Anthony Basile gentoo-dev 2015-12-09 21:29:41 UTC
(In reply to Oleg from comment #2)
> any progress on this? the fix is about the same like in bitcoin-qt

i'm sorry Oleg, but this is really low on my priority list.  Can you prepare a patch
Comment 4 Oleh 2015-12-16 12:59:32 UTC
Created attachment 419338 [details, diff]
patch
Comment 5 Oleh 2015-12-16 12:59:54 UTC
Created attachment 419340 [details]
updated ebuild
Comment 6 Oleh 2015-12-16 13:02:12 UTC
Created attachment 419342 [details, diff]
ebuild diff
Comment 7 Anthony Basile gentoo-dev 2015-12-16 17:15:39 UTC
Thanks Oleg, I committed this for both litecoind and litecoin-qt.   You shouldn't apply patches contingent on USE flags, so I removed that.

There is however, a problem with executable gnu stack that I should take care of.  If you have time to look at that I'd appreciate it.

Please test and let me know if there's any problems.  Reopen this bug if there is.
Comment 8 Anthony Basile gentoo-dev 2015-12-16 17:36:31 UTC
(In reply to Anthony Basile from comment #7)

> 
> There is however, a problem with executable gnu stack that I should take
> care of.  If you have time to look at that I'd appreciate it.
> 

Actually don't spend too much time on the gnu stack issue, I've got a handle on it.