566554 – sci-misc/flashdot: calls use in global scope

Bug 566554 - sci-misc/flashdot: calls use in global scope

Summary: sci-misc/flashdot: calls use in global scope

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Thomas Kahle (RETIRED)

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	global-scope-use
	Show dependency tree

Reported:	2015-11-22 23:05 UTC by Michał Górny
Modified:	2015-11-23 10:47 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michał Górny archtester

2015-11-22 23:05:01 UTC

MAKEOPTS="-j1 VERSION=${PV}"
use ocamlopt || MAKEOPTS="${MAKEOPTS} TARGETS=flashdot_bytecode BYTECODENAME=flashdot"

'use' is disallowed in global scope, so this needs to go into phase. Furthermore, please don't use or alter MAKEOPTS. Instead, pass your own custom variable.

Comment 1 Justin Lecher (RETIRED) gentoo-dev

2015-11-23 10:47:22 UTC

commit 5c5d388cd7a9888abe57ea54570fb11ee71acc50
Author: Justin Lecher <jlec@gentoo.org>
Date:   Mon Nov 23 11:35:19 2015 +0100

    sci-misc/flashdot: Move use() call to local scope

    bump EAPI to 5

    Gentoo-Bug: https://bugs.gentoo.org/show_bug.cgi?id=566554

    Package-Manager: portage-2.2.25
    Signed-off-by: Justin Lecher <jlec@gentoo.org>

    https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5c5d388cd7a9888abe57ea54570fb11ee71acc50