Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 564846 - sys-apps/openrc-0.18.2 netmount config file incorrect comment for rc_need and NetworkManager
Summary: sys-apps/openrc-0.18.2 netmount config file incorrect comment for rc_need and...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: OpenRC Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-04 06:46 UTC by Fitzcarraldo
Modified: 2015-11-11 21:56 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fitzcarraldo 2015-11-04 06:46:27 UTC
There is an incorrect comment in the netmount initscript configuration file for stable sys-apps/openrc-0.17 and testing sys-apps/openrc-0.18.2

The file /etc/conf.d/netmount contains comments with instructions on what to specify for rc_need:

# You will need to set the dependencies in the netmount script to match
# the network configuration tools you are using. This should be done in
# this file by following the examples below, and not by changing the
# service script itself.
#
# Each of these examples is meant to be used separately. So, for
# example, do not set rc_need to something like "net.eth0 dhcpcd".
#
# If you are using newnet and configuring your interfaces with static
# addresses with the network script, you  should use this setting.
#
#rc_need="network"
#
# If you are using oldnet, you must list the specific net.* services you
# need.
#
# This example assumes all of your netmounts can be reached on
# eth0.
#
#rc_need="net.eth0"
#
# This example assumes some of your netmounts are on eth1 and some
# are on eth2.
#
#rc_need="net.eth1 net.eth2"
#
# If you are using a dynamic network management tool like
# networkmanager, dhcpcd in standalone mode, wicd, badvpn-ncd, etc, to
# manage the network interfaces with the routes to your netmounts, you
# should list that tool.
#
#rc_need="networkmanager"
#rc_need="dhcpcd"
#rc_need="wicd"
#
# The default setting is designed to be backward compatible with our
# current setup, but you are highly discouraged from using this. In
# other words, please change it to be more suited to your system.
#
rc_need="net"

However, the following comment:

#rc_need="networkmanager"

needs to be changed to:

#rc_need="NetworkManager"


Reproducible: Always

Steps to Reproduce:
As I am using NetworkManager rather than netifrc, I followed the instructions in the /etc/conf.d/netmount file's comments and changed that file's contents from:

rc_need="net"

to:

rc_need="networkmanager"
Actual Results:  
After making the above change, the console messages at boot-up included a new message:

* ERROR: netmount needs service(s) networkmanager

That message made sense: rc_need had been set to "networkmanager" and, obviously, netmount can only do its job if NetworkManager is running (AND a network connection has been established).

Expected Results:  
However, notice that the name of the NetworkManager service initscript is /etc/init.d/NetworkManager, not /etc/init.d/networkmanager. In other words, the instructions in /etc/conf.d/netmount are wrong: the name of the service is actually 'NetworkManager', not 'networkmanager'. So I changed /etc/conf.d/netmount to contain rc_need="NetworkManager" instead of rc_need="networkmanager" and, unsurprisingly, the above-mentioned error message no longer occurs. So the comment in the confgi file needs to be changed.
Comment 1 William Hubbs gentoo-dev 2015-11-11 21:56:33 UTC
https://github.com/openrc/openrc/commit/ddb895b

This will be in OpenRC-0.19.