Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 563026 - =media-video/openshot-1.4.3 RDEPEND correction for ffmpeg/libav part
Summary: =media-video/openshot-1.4.3 RDEPEND correction for ffmpeg/libav part
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Louis Sautier (sbraz)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-14 00:19 UTC by Mikhail Kurinnoi
Modified: 2016-03-16 10:03 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Screenshot that show the issue. (Screenshot_2015-10-15_23-42-51.jpg,185.60 KB, image/jpeg)
2015-10-15 20:48 UTC, Mikhail Kurinnoi
Details
openshot-1.4.3-ffmpeg_vpx_not_theora.patch (openshot-1.4.3-ffmpeg_vpx_not_theora.patch,607 bytes, patch)
2016-02-21 17:05 UTC, Marek Szuba
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Kurinnoi 2015-10-14 00:19:42 UTC
RDEPEND should have media-video/ffmpeg and media-video/libav with USE="vpx" also, or WebM format will not work.

Reproducible: Always
Comment 1 Pacho Ramos gentoo-dev 2015-10-15 19:29:41 UTC
What is the concrete error do you get? Thanks
Comment 2 Mikhail Kurinnoi 2015-10-15 20:48:05 UTC
Created attachment 414654 [details]
Screenshot that show the issue.

This is not an error, but warning during program execution that WebM can't be used (screenshot attached), and, yes, WebM can't be used without USE="vpx" for ffmpeg package.
Comment 3 Pacho Ramos gentoo-dev 2015-10-17 10:32:02 UTC
I am unsure if this runtime only dep should be added to openshot, I mean, if people don't want this format or they want it, they should toggle it in the ffmpeg package ... but why force it to be on for everybody if people won't use that format?
Comment 4 Mikhail Kurinnoi 2015-10-17 13:38:51 UTC
I am just asking about USE="vpx" flag for openshot, so people will see disabled feature and can decide by yourself need them WebM or not. And, if WebM them need, portage will route them to ffmpeg/libav and "vpx" flag, as it should be imho. But for now we have situation "guess which package have exactly same libvpx what openshot need for WebM" or "where should I find libavformat-extra package or something for Gentoo to make it work"...
Comment 5 Marek Szuba archtester gentoo-dev 2016-02-21 17:05:01 UTC
Created attachment 426134 [details, diff]
openshot-1.4.3-ffmpeg_vpx_not_theora.patch

While I agree with Pacho about the "force it to be on for everybody" bit, unfortunately this is what the current OpenShot ebuild already does for other formats we so might as well add USE=vpx to the list... or even better, given Theora never really took off and it was VP8 who made it into WebM instead, have USE=vpx replace USE=theora. Please find attached a patch which takes care of that.

That said, OpenShot-2.0 has reached its third beta version and I have begun looking into writing an ebuild for it. Given it will be quite different from that of the 1.4 branch, I believe it will be a good opportunity to improve the way of handling ffmpeg/libav USE flags as well.
Comment 6 Patrice Clement gentoo-dev 2016-03-16 10:03:25 UTC
commit faab5c6e5381c7f764eea499ff3f531ab6249980 (HEAD -> master)
Author:     Louis Sautier <sautier.louis@gmail.com>
AuthorDate: Wed Mar 16 10:45:35 2016 +0100
Commit:     Patrice Clement <monsieurp@gentoo.org>
CommitDate: Wed Mar 16 09:49:38 2016 +0000

media-video/openshot: require ffmpeg/libav to be compiled with USE=vpx

Gentoo-Bug: https://bugs.gentoo.org/563026
Package-Manager: portage-2.2.27
Closes: https://github.com/gentoo/gentoo/pull/1068

media-video/openshot/openshot-1.4.3-r1.ebuild | 61 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
media-video/openshot/openshot-1.4.3.ebuild    | 61 -------------------------------------------------------------
2 files changed, 61 insertions(+), 61 deletions(-)
create mode 100644 media-video/openshot/openshot-1.4.3-r1.ebuild
delete mode 100644 media-video/openshot/openshot-1.4.3.ebuild