Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 562020 - net-p2p/transmission-2.84-r1 build fails with net-libs/miniupnpc-1.9.20150917-r1
Summary: net-p2p/transmission-2.84-r1 build fails with net-libs/miniupnpc-1.9.20150917-r1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: Gentoo net-p2p team
URL:
Whiteboard:
Keywords:
: 562074 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-10-02 08:59 UTC by Märt Bakhoff
Modified: 2015-10-04 15:51 UTC (History)
7 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
fix compatibility with miniupnp api 14 (upnp_ttl.patch,704 bytes, patch)
2015-10-02 14:11 UTC, Sander Sweers
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Märt Bakhoff 2015-10-02 08:59:30 UTC
miniupnpc was just version bumped from 1.9.20150427 to 1.9.20150917. 
transmission build now fails: 

upnp.c:91:9: error: too few arguments to function ‘upnpDiscover’
   ret = upnpDiscover (msec, NULL, NULL, 0, 0, &err);


Reproducible: Always
Comment 1 Sander Sweers 2015-10-02 13:53:11 UTC
They broke api and added a ttl argument (unsigned char), see https://github.com/miniupnp/miniupnp/commit/1da63faa4fff5cb30e5d4b848ceef80a292382b9.

The default for ttl as mentioned in the code/commit should be two so,
ret = upnpDiscover (msec, NULL, NULL, 0, 0, &err);

should be
ret = upnpDiscover (msec, NULL, NULL, 0, 0, 2, &err);

I'll try to create a patch and post it here for ppl.
Comment 2 Sander Sweers 2015-10-02 14:11:06 UTC
Created attachment 413502 [details, diff]
fix compatibility with miniupnp api 14
Comment 3 Emanuel Dávila 2015-10-02 21:19:50 UTC
(In reply to Sander Sweers from comment #2)
> Created attachment 413502 [details, diff] [details, diff]
> fix compatibility with miniupnp api 14

works good for me, thanks
Comment 4 Scott Ellis 2015-10-03 15:56:28 UTC
(In reply to Sander Sweers from comment #2)
> Created attachment 413502 [details, diff] [details, diff]
> fix compatibility with miniupnp api 14

Much appreciated.
Comment 5 Mike Gilbert gentoo-dev 2015-10-03 17:08:45 UTC
*** Bug 562074 has been marked as a duplicate of this bug. ***
Comment 6 Mike Gilbert gentoo-dev 2015-10-03 18:28:45 UTC
(In reply to Sander Sweers from comment #2)

I have committed this patch in the gentoo repository.

Could you submit your patch upstream and provide a link back to here?

https://trac.transmissionbt.com/report
Comment 7 Sander Sweers 2015-10-03 19:55:06 UTC
(In reply to Mike Gilbert from comment #6)
> Could you submit your patch upstream and provide a link back to here?

Yes but they feel the need to moderate bugs from new bug accounts so I have no url at this time. When I have it I'll post it.
Comment 9 Mike Gilbert gentoo-dev 2015-10-04 15:51:36 UTC
Thanks!

commit 92028dec3c192e6d8693d0d2b73b3ef3e7dfe522
Author: Mike Gilbert <floppym@gentoo.org>
Date:   Sun Oct 4 11:50:38 2015 -0400

    net-p2p/transmission: Use upstream patch for miniupnpc 14
    
    Package-Manager: portage-2.2.22_p5

 net-p2p/transmission/files/2.84-miniupnp14.patch | 21 ++++++++-------------
 1 file changed, 8 insertions(+), 13 deletions(-)