Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 561792 - sys-apps/portage-2.2.22 (python-2.7) - test{Compile,Import}Modules: SyntaxError: invalid syntax
Summary: sys-apps/portage-2.2.22 (python-2.7) - test{Compile,Import}Modules: SyntaxErr...
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Unclassified (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: REGRESSION
Depends on:
Blocks: 549914
  Show dependency tree
 
Reported: 2015-09-29 08:57 UTC by tka
Modified: 2015-10-09 15:16 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,329.98 KB, text/plain)
2015-09-29 08:58 UTC, tka
Details

Note You need to log in before you can comment on or make changes to this bug.
Description tka 2015-09-29 08:57:37 UTC
portage-2.2.22 fails two tests: testCompileModules and testImportModules due to invalid-syntax errors. This happens with python-2.7. There are no test failures with python-3.4.


======================================================================
ERROR: testCompileModules (portage.tests.lint.test_compile_modules.CompileModulesTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/var/tmp/portage/sys-apps/portage-2.2.22/work/portage-2.2.22-python2_7/lib/portage/tests/__init__.py", line 222, in run
    testMethod()
  File "/var/tmp/portage/sys-apps/portage-2.2.22/work/portage-2.2.22-python2_7/lib/portage/tests/lint/test_compile_modules.py", line 67, in testCompileModules
    compile(f.read(), x, 'exec')
  File "/var/tmp/portage/sys-apps/portage-2.2.22/work/portage-2.2.22-python2_7/lib/repoman/results.py", line 366
    print("* %s files being committed..." % green(str(len(myupdates))), end=' ')
                                                                           ^
SyntaxError: invalid syntax

======================================================================
ERROR: testImportModules (portage.tests.lint.test_import_modules.ImportModulesTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/var/tmp/portage/sys-apps/portage-2.2.22/work/portage-2.2.22-python2_7/lib/portage/tests/__init__.py", line 222, in run
    testMethod()
  File "/var/tmp/portage/sys-apps/portage-2.2.22/work/portage-2.2.22-python2_7/lib/portage/tests/lint/test_import_modules.py", line 22, in testImportModules
    __import__(mod)
  File "/var/tmp/portage/sys-apps/portage-2.2.22/work/portage-2.2.22-python2_7/lib/repoman/results.py", line 366
    print("* %s files being committed..." % green(str(len(myupdates))), end=' ')
                                                                           ^
SyntaxError: invalid syntax

======================================================================


Reproducible: Always

Steps to Reproduce:
1. Set FEATURES=test and PYTHON_TARGETS=python2_7
2. emerge portage




# emerge --info '=sys-apps/portage-2.2.22::gentoo'
Portage 2.2.20.1 (python 3.4.3-final-0, hardened/linux/amd64/no-multilib, gcc-4.9.3, glibc-2.21-r1, 4.2.1 x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-4.2.1-x86_64-Intel-R-_Core-TM-_i7-3720QM_CPU_@_2.60GHz-with-gentoo-2.2
KiB Mem:    16400252 total,  13729464 free
KiB Swap:   17825788 total,  17825788 free
Timestamp of repository gentoo: Tue, 29 Sep 2015 08:00:01 +0000
sh bash 4.3_p42
ld GNU ld (Gentoo 2.25.1 p1.1) 2.25.1
app-shells/bash:          4.3_p42::gentoo
dev-java/java-config:     2.2.0::gentoo
dev-lang/perl:            5.22.0::gentoo
dev-lang/python:          2.7.10::gentoo, 3.4.3::gentoo
dev-util/cmake:           3.3.2::gentoo
dev-util/pkgconfig:       0.28-r3::gentoo
sys-apps/baselayout:      2.2::gentoo
sys-apps/openrc:          0.17::gentoo
sys-apps/sandbox:         2.9::gentoo
sys-devel/autoconf:       2.13::gentoo, 2.69-r1::gentoo
sys-devel/automake:       1.11.6-r1::gentoo, 1.14.1::gentoo, 1.15::gentoo
sys-devel/binutils:       2.25.1-r1::gentoo
sys-devel/gcc:            4.7.4::gentoo, 4.8.5::gentoo, 4.9.3::gentoo
sys-devel/gcc-config:     1.8::gentoo
sys-devel/libtool:        2.4.6-r1::gentoo
sys-devel/make:           4.1-r1::gentoo
sys-kernel/linux-headers: 4.2::gentoo (virtual/os-headers)
sys-libs/glibc:           2.21-r1::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000

local
    location: /var/lib/portage-local/local
    masters: gentoo
    priority: 0

testing
    location: /var/lib/portage-local/testing
    masters: gentoo
    priority: 1

science
    location: /var/lib/layman/science
    masters: gentoo
    priority: 50

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -mtune=native -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-march=native -mtune=native -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
EMERGE_DEFAULT_OPTS="--with-bdeps=y"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs cgroup collision-protect config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync network-sandbox news parallel-fetch preserve-libs protect-owned sandbox sfperms strict test unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu"
MAKEOPTS="-j8"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
USE="X a52 acl acpi alsa amd64 avx berkdb bzip2 cairo caps cdda cddb cdparanoia cli cracklib crypt cups cxx dbus dri dts dvd fam ffmpeg fftw flac fontconfig foomaticdb gdbm gif gimp gmp gnutls gtk hardened iconv icu idn ipv6 jpeg justify lame lcms libnotify lzma mad matroska mmap mmx mmxext modules mp3 mpeg ncurses networkmanager nptl ogg opengl openmp pam pcre pie png policykit ppds readline sasl sdl seccomp session sse sse2 sse3 sse4 sse4_1 sse4_2 ssl ssp ssse3 startup-notification svg tcpd theora threads tiff truetype udev udisks unicode upower vaapi vorbis wayland x264 xattr xcb xml xtpax xv xvid zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx mmx mmxext popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ublox ubx" GRUB_PLATFORMS="pc" INPUT_DEVICES="evdev synaptics" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-5" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_4" RUBY_TARGETS="ruby20 ruby21" USERLAND="GNU" VIDEO_CARDS="i965 intel nouveau" XFCE_PLUGINS="battery brightness logout menu power trash" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, INSTALL_MASK, LANG, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON

# emerge -pqv '=sys-apps/portage-2.2.22::gentoo'
[ebuild     U ] sys-apps/portage-2.2.22 [2.2.20.1] USE="(ipc) (xattr) -build -doc -epydoc (-selinux)" LINGUAS="-ru" PYTHON_TARGETS="python2_7 python3_4 -pypy -python3_3"
Comment 1 tka 2015-09-29 08:58:38 UTC
Created attachment 413242 [details]
build.log
Comment 2 Zac Medico gentoo-dev 2015-09-29 15:59:28 UTC
It seems that portage-2.2.22/pym/repoman/results.py is a stray file that doesn't belong in the tarball. I guess our release packing script needs to call git clean, or use another approach such as to export the files for a tag with git archive.
Comment 3 Brian Dolbec (RETIRED) gentoo-dev 2015-09-29 21:35:57 UTC
oops, my bad...

During the re-write process, I ended up renaming the file as more and more things were evident that they needed to remain in the one file.

That file did not get the 

"from __future__ import print_function" 

which would have prevented that error.  I just went thru my checkout and there is also likely to to be an output.py file in that same directory.

Since the main test suite is run via the github mirror, that error would not occur.

I will likely be releasing a point release this weekend with a few bugfixes. In the meantime, this particular bug is not going to affect the running of portage/emerge.
Comment 4 Brian Dolbec (RETIRED) gentoo-dev 2015-10-09 15:16:58 UTC
Released in portage-2.2.23