Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 55936 - mplayer cachefill option in mplayer.conf
Summary: mplayer cachefill option in mplayer.conf
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High enhancement (vote)
Assignee: Brian Harring (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-07-02 22:03 UTC by Jeremy Huddleston (RETIRED)
Modified: 2004-07-23 13:12 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
mplayer-cacheprefill_option.patch (mplayer.patch,4.64 KB, patch)
2004-07-02 22:06 UTC, Jeremy Huddleston (RETIRED)
Details | Diff
updated patch (mplayer.patch,4.45 KB, patch)
2004-07-03 02:26 UTC, Jeremy Huddleston (RETIRED)
Details | Diff
updated to fix an mplayer cache fill bug also (mplayer.patch,5.12 KB, patch)
2004-07-03 04:36 UTC, Jeremy Huddleston (RETIRED)
Details | Diff
some runtime optimizations (mplayer.cache.patch,5.91 KB, patch)
2004-07-22 21:16 UTC, Jeremy Huddleston (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Huddleston (RETIRED) gentoo-dev 2004-07-02 22:03:49 UTC
I created a patch which allows the user to set the percentage full the cache reaches before playback.  Default is set to the current hardcoded value (5% / 20%).  I haven't sent it upstream yet.
Comment 1 Jeremy Huddleston (RETIRED) gentoo-dev 2004-07-02 22:06:59 UTC
Created attachment 34688 [details, diff]
mplayer-cacheprefill_option.patch

Alters example.conf to show usage.
I also increased the maximum cache size to 256M from 64M.

The default is for the prefill value to be a percentage (20% initial / 5% on
restart) of the cache size, but when you increase to larger caches for better
network streaming, the fill time increases proportionally... and at 256M the
20% becomes unreasonable.
Comment 2 Chris White (RETIRED) gentoo-dev 2004-07-03 00:25:38 UTC
ferringb:

I tested it over here, works ok on my side as well.

Sent it upstream too.
Comment 3 Jeremy Huddleston (RETIRED) gentoo-dev 2004-07-03 02:26:40 UTC
Created attachment 34695 [details, diff]
updated patch

options use - instead of _
max is now 99 to fix bug with 100
Comment 4 Jeremy Huddleston (RETIRED) gentoo-dev 2004-07-03 04:36:05 UTC
Created attachment 34703 [details, diff]
updated to fix an mplayer cache fill bug also

Alright, I've worked with the upstream devs, and this adds the feature as well
as fixes the predicate on the initial fill... they should be having it in the
next release, so feel free to mark this UPSTREAM if you're too busy to add it
in
Comment 5 Jeremy Huddleston (RETIRED) gentoo-dev 2004-07-22 21:16:55 UTC
Created attachment 35984 [details, diff]
some runtime optimizations

forgot to attach the final patch... this is the one I finally worked out with
upstream input... has some optimizations over the previous one...
Comment 6 Brian Harring (RETIRED) gentoo-dev 2004-07-23 13:12:15 UTC
Currently InCVS as of yesterday for 1.0_pre4-r5 and 1.0_pre5-r1