# /etc/init.d/shorewall restart * Please use 'svc_stop; svc_start' and not 'start; stop' to * restart the service in its custom 'restart()' function. * Run shorewall without arguments for more info. * Stopping firewall... /usr/share/shorewall/firewall: line 112: $RESTOREBASE: ambiguous redirect /usr/share/shorewall/firewall: line 113: $RESTOREBASE: ambiguous redirect /usr/share/shorewall/firewall: line 114: $RESTOREBASE: ambiguous redirect /usr/share/shorewall/firewall: line 125: $RESTOREBASE: ambiguous redirect [ ok ] * Starting firewall... # # Write a progress_message command to $RESTOREBASE # save_progress_message() { echo >> $RESTOREBASE echo "progress_message \"$@\"" >> $RESTOREBASE echo >> $RESTOREBASE } # # Save the passed command in the restore script then run it -- returns the status of the command # If the command involves file redirection then it must be enclosed in quotes as in: # # run_and_save_command "echo 1 > /proc/sys/net/ipv4/ip_forward" # run_and_save_command() { echo "$@" >> $RESTOREBASE eval $* } [ ok ] --------------- Reproducible: Always Steps to Reproduce: 1. /etc/init.d/shorewall stop
My message got missformatted... repeating. # /etc/init.d/shorewall restart * Please use 'svc_stop; svc_start' and not 'start; stop' to * restart the service in its custom 'restart()' function. * Run shorewall without arguments for more info. * Stopping firewall... /usr/share/shorewall/firewall: line 112: $RESTOREBASE: ambiguous redirect /usr/share/shorewall/firewall: line 113: $RESTOREBASE: ambiguous redirect /usr/share/shorewall/firewall: line 114: $RESTOREBASE: ambiguous redirect /usr/share/shorewall/firewall: line 125: $RESTOREBASE: ambiguous redirect [ ok ] * Starting firewall... [ ok ] --------------- # # Write a progress_message command to $RESTOREBASE # save_progress_message() { echo >> $RESTOREBASE echo "progress_message \"$@\"" >> $RESTOREBASE echo >> $RESTOREBASE } # # Save the passed command in the restore script then run it -- returns the status of the command # If the command involves file redirection then it must be enclosed in quotes as in: # # run_and_save_command "echo 1 > /proc/sys/net/ipv4/ip_forward" # run_and_save_command() { echo "$@" >> $RESTOREBASE eval $* }
i've just sent a mail to shorewall-users
Fixed Upstream?
Fixes two problems: * Error messages regarding $RESTOREBASE occur during shorewall stop. * If CLEAR_TC=Yes in shorewall.conf, shorewall stop fails without removing the lock file. http://shorewall.net/pub/shorewall/shorewall-2.0.3c ftp://shorewall.net/pub/shorewall/shorewall-2.0.3c
2.0.3c works here time to get into portage
Right! Awaiting for CVS update.
now in cvs closing with 2.0.3c
Nice work :)
Martin, close the bug :)