Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 552720 - repoman: Allow DOCTYPE SYSTEM https://www.gentoo.org/dtd/metadata.dtd
Summary: repoman: Allow DOCTYPE SYSTEM https://www.gentoo.org/dtd/metadata.dtd
Status: IN_PROGRESS
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Repoman (show other bugs)
Hardware: All Linux
: Normal major with 1 vote (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2015-06-21 10:28 UTC by Justin Lecher
Modified: 2018-03-28 07:50 UTC (History)
9 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Lecher gentoo-dev 2015-06-21 10:28:20 UTC
As gentoo is now doing ssl by defaut, we should be able to specify 

https://www.gentoo.org/dtd/metadata.dtd

instead of

http://www.gentoo.org/dtd/metadata.dtd

in metadata.xml and thus repoman should at least except both if not correct to https silently.
Comment 1 Justin Lecher gentoo-dev 2015-08-24 14:11:18 UTC
Could we please get this fixed?
Comment 2 Justin Lecher gentoo-dev 2015-08-24 14:13:57 UTC
Pyhton 2.7:

repoman full --xmlparse -d

RepoMan scours the neighborhood...
>>> Creating Manifest for /local/home/justin/tree/media-libs/simage
  metadata.bad [fatal]          1
   media-libs/simage/metadata.xml: DOCTYPE: SYSTEM should refer to 'http://www.gentoo.org/dtd/metadata.dtd', not 'https://www.gentoo.org/dtd/metadata.dtd'
  repo.eapi.deprecated          1
   media-libs/simage/simage-1.7.0.ebuild: 2
Please fix these important QA issues first.
RepoMan sez: "Make your QA payment on time and you'll never see the likes of me."


Python 3.4:

justin@paul ~/tree/media-libs/simage $ (1) repoman full --xmlparse -d

RepoMan scours the neighborhood...
>>> Creating Manifest for /local/home/justin/tree/media-libs/simage
  repo.eapi.deprecated          1
   media-libs/simage/simage-1.7.0.ebuild: 2
RepoMan sez: "You're only giving me a partial QA payment?
              I'll take it this time, but I'm not happy."
Comment 3 Mike Gilbert gentoo-dev 2015-08-24 19:47:48 UTC
(In reply to Justin Lecher from comment #2)

It seems you found a bug in the XML parsing code under python3.

I would suggest reverting your mass-update until repoman has actually been updated to accommodate it.
Comment 4 Mike Gilbert gentoo-dev 2015-08-24 20:45:41 UTC
With QA's blessing, I reverted the http -> https conversion in metadata.xml for now.
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-02-04 13:48:53 UTC
repoman patch sent for review.
Comment 6 Larry the Git Cow gentoo-dev 2018-02-05 18:46:29 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=3950d76df63cf0f3f6502014dd61b8aa9c260e36

commit 3950d76df63cf0f3f6502014dd61b8aa9c260e36
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2018-02-04 13:34:33 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2018-02-05 18:45:38 +0000

    repoman: Update metadata.dtd URI to allow https://
    
    Update the default metadata.dtd URI used in repoman and Portage tests
    to use https://. However, allow also http:// form for the migration
    period.
    
    The http:// compat can be removed once the Gentoo repository is updated
    to use https:// everywhere.
    
    Bug: https://bugs.gentoo.org/552720
    Closes: https://github.com/gentoo/portage/pull/255
    Reviewed-by: Zac Medico <zmedico@gentoo.org>

 pym/portage/tests/resolver/ResolverPlayground.py         | 2 +-
 repoman/pym/repoman/metadata.py                          | 2 +-
 repoman/pym/repoman/modules/scan/metadata/pkgmetadata.py | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)}