551162 – dev-libs/libindicate-12.10.1-r1: incorrect use of nonfatal

Bug 551162 - dev-libs/libindicate-12.10.1-r1: incorrect use of nonfatal

Summary: dev-libs/libindicate-12.10.1-r1: incorrect use of nonfatal

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Ayatana Bugs

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	bad-nonfatal
	Show dependency tree

Reported:	2015-06-04 09:05 UTC by Michał Górny
Modified:	2015-09-24 19:08 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michał Górny archtester

2015-06-04 09:05:54 UTC

nonfatal dosym /usr/share/doc/${PF}/html/${PN} /usr/share/gtk-doc/html/${PN}


This is just plain wrong... dosym can only fail if ${D}/usr/share/gtk-doc/html doesn't exist... so wtf?

Also, please just respect standard upstream gtk-doc install location instead of enforcing meaningless, creepy /usr/share/doc/${PF}/html...

Comment 1 Johannes Huber (RETIRED) gentoo-dev

2015-07-01 15:28:45 UTC

@Michał Feel free to make the changes.

Comment 2 Michał Górny archtester

2015-07-01 18:27:52 UTC

+*libindicate-12.10.1-r2 (01 Jul 2015)
+
+  01 Jul 2015; Michał Górny <mgorny@gentoo.org> +libindicate-12.10.1-r2.ebuild:
+  Combine sed calls. Fix gtk-doc install path (and incorrect nonfatal use), bug
+  #551162.

Comment 3 Alexander Tsoy 2015-09-24 19:08:40 UTC

JFYI: there are two problems with this change:

1. Orphaned directory and symlink are left after upgrade:
# qfile -o /usr/share/doc/*
/usr/share/doc/libindicate-12.10.1-r1
# stat --printf='%N\n' /usr/share/gtk-doc/html/libindicate
«/usr/share/gtk-doc/html/libindicate» -> «/usr/share/doc/libindicate-12.10.1-r1/html/libindicate»

So the following is shown after package merges:
 * One or more symlinks to directories have been preserved in order to
 * ensure that files installed via these symlinks remain accessible. This
 * indicates that the mentioned symlink(s) may be obsolete remnants of an
 * old install, and it may be appropriate to replace a given symlink with
 * the directory that it points to.
 * 
 *  /usr/share/gtk-doc/html/libindicate
 * 

2. Examples are installed into /usr/share/doc/${PN}

# qfile /usr/share/doc/libindicate*
dev-libs/libindicate (/usr/share/doc/libindicate-12.10.1-r2)
dev-libs/libindicate (/usr/share/doc/libindicate)
# ls /usr/share/doc/libindicate/
examples