Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 551156 - intel-sdp.eclass: incorrect use of nonfatal
Summary: intel-sdp.eclass: incorrect use of nonfatal
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Justin Lecher (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: bad-nonfatal
  Show dependency tree
 
Reported: 2015-06-04 08:56 UTC by Michał Górny
Modified: 2015-06-04 10:22 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2015-06-04 08:56:49 UTC 
if [[ -d "${INTEL_SDP_DIR}"/man ]]; then
        nonfatal doman "${INTEL_SDP_DIR}"/man/en_US/man1/*
        nonfatal doman "${INTEL_SDP_DIR}"/man/man1/*

This is incorrect. nonfatal is meant to be used to provide custom error handling, not ignore errors. You want to check for files matching the pattern properly (path_exists from eutils? package name/version matching?).
Comment 1 Justin Lecher (RETIRED) gentoo-dev 2015-06-04 10:22:58 UTC 
+  04 Jun 2015; Justin Lecher <jlec@gentoo.org> intel-sdp.eclass:
+  Fix homepage url for license registration, #538284; do a precheck instead fo
+  using nonfatal, #551156
+