Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 550824 - kde{4-base,5}.eclass - should RDEPEND on selinux policies
Summary: kde{4-base,5}.eclass - should RDEPEND on selinux policies
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 527868
  Show dependency tree
 
Reported: 2015-05-30 14:06 UTC by Jason Zaman
Modified: 2015-05-31 10:13 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Zaman gentoo-dev 2015-05-30 14:06:24 UTC
The SELinux policies should be RDEPEND'd on, not DEPEND. See the blocker bug for more info.
Something like the following should work:


Index: kde4-base.eclass
===================================================================
RCS file: /var/cvsroot/gentoo-x86/eclass/kde4-base.eclass,v
retrieving revision 1.152
diff -u -B -r1.152 kde4-base.eclass
--- kde4-base.eclass	15 May 2015 16:13:42 -0000	1.152
+++ kde4-base.eclass	30 May 2015 14:05:32 -0000
@@ -370,7 +370,7 @@
 	none)	;;
 	*)
 		IUSE+=" selinux"
-		kdecommondepend+=" selinux? ( sec-policy/selinux-${KDE_SELINUX_MODULE} )"
+		kderdepend+=" selinux? ( sec-policy/selinux-${KDE_SELINUX_MODULE} )"
 		;;
 esac
 
Index: kde5.eclass
===================================================================
RCS file: /var/cvsroot/gentoo-x86/eclass/kde5.eclass,v
retrieving revision 1.8
diff -u -B -r1.8 kde5.eclass
--- kde5.eclass	9 May 2015 15:33:21 -0000	1.8
+++ kde5.eclass	30 May 2015 14:05:32 -0000
@@ -197,7 +197,7 @@
 	none)   ;;
 	*)
 		IUSE+=" selinux"
-		COMMONDEPEND+=" selinux? ( sec-policy/selinux-${KDE_SELINUX_MODULE} )"
+		RDEPEND+=" selinux? ( sec-policy/selinux-${KDE_SELINUX_MODULE} )"
 		;;
 esac
Comment 1 Johannes Huber (RETIRED) gentoo-dev 2015-05-30 14:32:50 UTC
@Jason ack from kde, just apply it
Comment 2 Jason Zaman gentoo-dev 2015-05-31 10:13:14 UTC
Thanks, done.

31 May 2015; Jason Zaman <perfinion@gentoo.org> kde4-base.eclass, kde5.eclass:
KDE: fix SELinux deps, bug 550824