Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 550540 - sys-freebsd/ubin-wrappers-0 relies on dowrap script being executable
Summary: sys-freebsd/ubin-wrappers-0 relies on dowrap script being executable
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: FreeBSD (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Richard Yao (RETIRED)
URL:
Whiteboard:
Keywords: QAcanfix
Depends on:
Blocks: 550434
  Show dependency tree
 
Reported: 2015-05-27 11:55 UTC by Ulrich Müller
Modified: 2015-05-30 08:28 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Proposed patch for ubin-wrappers-0.ebuild (ubin-wrappers-0.ebuild.diff,1.14 KB, patch)
2015-05-28 09:42 UTC, Ulrich Müller
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2015-05-27 11:55:21 UTC
In src_install():

    "${FILESDIR}/dowrap" "${EPREFIX}/bin/"{bunzip2,bzcat,cpio,egrep,fgrep,grep,gunzip,gzip,zcat}

This relies on ${FILESDIR}/dowrap being executable. Please prefix the above line with an explicit /bin/bash call.
Comment 1 Ulrich Müller gentoo-dev 2015-05-28 08:29:46 UTC
Looking at the dowrap script, it has more problems. It uses Portage internal functions (like helpers_die) and variables (like PORTAGE_INST_UID) which will make it fail with other package managers.

Maybe it would be best to inline this as a function into the ebuild. Patch will follow.
Comment 2 Ulrich Müller gentoo-dev 2015-05-28 09:42:29 UTC
Created attachment 404156 [details, diff]
Proposed patch for ubin-wrappers-0.ebuild

I've verified that the installed package is identical to the one installed by the existing ebuild.