Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 550092 - =dev-python/python-musicbrainz-ngs-0.5 version bump
Summary: =dev-python/python-musicbrainz-ngs-0.5 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: gerion
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-22 00:57 UTC by gerion
Modified: 2015-11-13 15:47 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
python-musicbrainz-ngs-0.5.ebuild (python-musicbrainz-ngs-0.5.ebuild,685 bytes, text/plain)
2015-11-09 11:53 UTC, gerion
Details
python-musicbrainzngs-0.5.ebuild (python-musicbrainzngs-0.5.ebuild,759 bytes, text/plain)
2015-11-12 14:48 UTC, gerion
Details
python-musicbrainz-ngs-0.5.ebuild (3rd try) (python-musicbrainz-ngs-0.5.ebuild,827 bytes, text/plain)
2015-11-13 13:57 UTC, gerion
Details
python-musicbrainz-ngs-0.5.ebuild (4th try) (python-musicbrainz-ngs-0.5.ebuild,983 bytes, text/plain)
2015-11-13 14:36 UTC, gerion
Details
python-musicbrainz-ngs-0.5.ebuild (5) (python-musicbrainz-ngs-0.5.ebuild,1.05 KB, text/plain)
2015-11-13 15:22 UTC, gerion
Details

Note You need to log in before you can comment on or make changes to this bug.
Description gerion 2015-05-22 00:57:14 UTC
The release of 0.5 was at 6 Feb 2014.

Moreover the projectname is now "python-musicbrainzngs".

Reproducible: Always




Changing the ebuild name to 0.5 and deleting the patch seems to be enough. The ebuild could be installed and the lib could be uses.

The patch is not needed anymore, I guess, see:
https://github.com/alastair/python-musicbrainzngs/commit/127bc0a077736c8ba2db7055e8b9072e098ffb8e
Comment 1 Pacho Ramos gentoo-dev 2015-11-08 12:14:27 UTC
are you willing to proxy maintain this?
https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers
Comment 2 gerion 2015-11-09 11:52:41 UTC
Yes, I can do this. I have a high interest in MusicBrainz and this package and some python skills. Nevertheless my ebuild writing knowledge is existent, but not complete.
Comment 3 gerion 2015-11-09 11:53:47 UTC
Created attachment 416358 [details]
python-musicbrainz-ngs-0.5.ebuild

ebuild for v0.5
Comment 4 Pacho Ramos gentoo-dev 2015-11-09 14:21:54 UTC
CCing proxy maintainer then

Thanks
Comment 5 Ian Delaney (RETIRED) gentoo-dev 2015-11-12 04:33:02 UTC
DOCS=(README.md CHANGES)
use examples && DOCS+=( examples )

The python eclass will install files to location for DOCS internally, or by default

The line use examples && DOCS+=( examples ) is left out in global space where it is actually 'illegally' placed by ebuild writing rules.

There are many examples of the use of IUSE examples in the <cat> dev-python.
It needs by set within python_install_all().

It also appears that the examples are being mixed with DOCS.
There is in fact a folder docs that has a doc build which has not yet been addressed within the ebuild. This is an optional extra and one I routinely add in such ebuilds. Better to provide users with docs than not if they are they to be provided.
Comment 6 Ian Delaney (RETIRED) gentoo-dev 2015-11-12 04:48:23 UTC
Also feel to peruse https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers
and consider joining the channel listed there in which we offer first hand support to users.
Comment 7 gerion 2015-11-12 13:46:42 UTC
The uploaded ebuild is a copy of the previous one without the patch. I'll try to fix, what you comment.
Comment 8 gerion 2015-11-12 14:48:18 UTC
Created attachment 416768 [details]
python-musicbrainzngs-0.5.ebuild

2nd try
Comment 9 gerion 2015-11-12 14:53:22 UTC
Changes:
- rename to python-musicbrainzngs, add blocker for python-musicbrainz-ngs.
  The only other ebuild that uses it, is media-sound/beets
- change download url to the one I found on github
- rename description to the one in setup.py
- remove explicit DOC
- do examples handling independently from doc in python_install_all

Problems:
- tests did not work. I tried the tests local (git clone and python setup.py test), and all tests passed. But with ebuild ... test the tests fail.
Comment 10 gerion 2015-11-12 14:54:43 UTC
(btw, i'm bouncing in the channel now)
Comment 11 Ian Delaney (RETIRED) gentoo-dev 2015-11-13 01:33:07 UTC
ok seeing you have joined in irc I shall just make brief notes here for the purpose of documenting progress.

The ebuild needs keeping to the name in portage and use of 'bash magic' to re-define {S}.
There is an abbreviated version that substitutes hopw you wrote the test phase.
The doc build can be done but likely down the track.
Comment 12 gerion 2015-11-13 13:57:58 UTC
Created attachment 416844 [details]
python-musicbrainz-ngs-0.5.ebuild (3rd try)

next try

Changes:
- rename to old name and fix URI and S variables
Comment 13 gerion 2015-11-13 14:36:20 UTC
Created attachment 416848 [details]
python-musicbrainz-ngs-0.5.ebuild (4th try)

Changes:
- remove blocker line
- add doc useflag for building and installing html documentation
Comment 14 gerion 2015-11-13 15:22:20 UTC
Created attachment 416854 [details]
python-musicbrainz-ngs-0.5.ebuild (5)

comments from idella4
Comment 15 Ian Delaney (RETIRED) gentoo-dev 2015-11-13 15:47:21 UTC
commit e4dae9de50707ae3503e28b0d2c5e01667a43757
Author: Ian Delaney <idella4@gentoo.org>
Date:   Fri Nov 13 23:44:45 2015 +0800

    dev-python/python-musicbrainz-ngs: bump to vn. 0.5
    
    add new proxy maintainer or metadata, submitted via, and closes,
    the gentoo bug, comes with a doc build and IUSE examples
    
    Gentoo bug: #550092