Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 545504 - games-misc/katawa-shoujo-1.3 version bump
Summary: games-misc/katawa-shoujo-1.3 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Alex Xu (Hello71)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-04 12:44 UTC by Pavel Volkov
Modified: 2015-04-15 12:32 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
katawa-shoujo-1.3.ebuild (katawa-shoujo-1.3.ebuild,1.95 KB, text/plain)
2015-04-04 12:45 UTC, Pavel Volkov
Details
katawa-shoujo-1.3.ebuild (katawa-shoujo-1.3.ebuild,1.99 KB, text/plain)
2015-04-04 17:50 UTC, Pavel Volkov
Details
katawa-shoujo-1.3.ebuild (katawa-shoujo-1.3.ebuild,2.06 KB, text/plain)
2015-04-04 21:22 UTC, Alex Xu (Hello71)
Details
katawa-shoujo-1.3.ebuild (katawa-shoujo-1.3.ebuild,2.13 KB, text/plain)
2015-04-04 22:18 UTC, Alex Xu (Hello71)
Details
katawa-shoujo-1.3.ebuild (katawa-shoujo-1.3.ebuild,2.13 KB, text/plain)
2015-04-04 23:34 UTC, Alex Xu (Hello71)
Details
katawa-shoujo-1.3.ebuild (katawa-shoujo-1.3.ebuild,2.24 KB, text/plain)
2015-04-05 14:59 UTC, Alex Xu (Hello71)
Details
katawa-shoujo-1.3.ebuild (katawa-shoujo-1.3.ebuild,2.22 KB, text/plain)
2015-04-12 02:45 UTC, Alex Xu (Hello71)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Volkov 2015-04-04 12:44:40 UTC
We now have an updated version 1.3 with x86_64 support, updated python/renpy and rpaths already correctly set.
Providing a new ebuild, tested game execution on ~amd64 but haven't played the game.
USE=system-renpy is probably safe now (removed warning).

Reproducible: Always
Comment 1 Pavel Volkov 2015-04-04 12:45:33 UTC
Created attachment 400544 [details]
katawa-shoujo-1.3.ebuild
Comment 2 Pavel Volkov 2015-04-04 17:50:30 UTC
Created attachment 400568 [details]
katawa-shoujo-1.3.ebuild
Comment 3 Alex Xu (Hello71) 2015-04-04 21:22:39 UTC
Created attachment 400572 [details]
katawa-shoujo-1.3.ebuild

> USE=system-renpy is probably safe now (removed warning).

but I wouldn't be surprised if it breaks.

in theory, we can provide LINGUAS support. in practice, the game doesn't handle lack of languages well (i.e. it crashes), and it's really not worth the effort in terms of disk space saved.
Comment 4 Pavel Volkov 2015-04-04 21:50:59 UTC
LGPL isn't a known license, there's LGPL-2, LGPL-3 etc. — my portage complains since it's not in @FREE.
Comment 5 Pavel Volkov 2015-04-04 21:54:59 UTC
Oh wait, it must be something else since I have +system-renpy...

melforce katawa-shoujo # e -1av katawa-shoujo

These are the packages that would be merged, in order:

Calculating dependencies... done!
[ebuild  N     ] dev-util/patchelf-0.8::gentoo  117 KiB
[ebuild     UD ] games-misc/katawa-shoujo-1.2-r2::gentoo [1.3::custom] USE="doc system-renpy" 471 891 KiB

Total: 2 packages (1 downgrade, 1 new), Size of downloads: 472 008 KiB

!!! The following updates are masked by LICENSE changes:
- games-misc/katawa-shoujo-1.3::custom (masked by: !system-renpy ( LGPL ) license(s))
For more information, see the MASKED PACKAGES section in the emerge
man page or refer to the Gentoo Handbook.


Would you like to merge these packages? [Yes/No] n

Quitting.

melforce katawa-shoujo # emerge --info|grep LICENSE
ACCEPT_LICENSE="@FREE MPEG-4 myspell-ru_RU-ALexanderLebedev freedist vim.org BitstreamCyberbit MSttfEULA grass-ipafonts free-noncomm CC-BY-NC-ND-3.0 CC-Sampling-Plus-1.0 google-chrome Oracle-BCLA-JavaSE RAR unRAR mac"
Comment 6 Pavel Volkov 2015-04-04 22:03:11 UTC
I guess portage is treating "!system-renpy", "(", ")" and "LGPL" as unknown license names and the syntax is wrong.
Comment 7 Alex Xu (Hello71) 2015-04-04 22:18:46 UTC
Created attachment 400574 [details]
katawa-shoujo-1.3.ebuild

(In reply to Pavel Volkov from comment #6)
> I guess portage is treating "!system-renpy", "(", ")" and "LGPL" as unknown
> license names and the syntax is wrong.

no, LICENSE is allowed to use USE-conditionals in EAPI 5.

you're right that LGPL isn't a license though.
Comment 8 Pavel Volkov 2015-04-04 22:31:41 UTC
Still repoman prints:

  LICENSE.invalid [fatal]       1
   games-misc/katawa-shoujo/katawa-shoujo-1.3.ebuild: !system-renpy

And emerge prints:

!!! The following updates are masked by LICENSE changes:
- games-misc/katawa-shoujo-1.3::custom (masked by: !system-renpy ( || ( ) ) license(s))
Comment 9 Pavel Volkov 2015-04-04 22:36:38 UTC
I see, you forgot the question mark.
Comment 10 Alex Xu (Hello71) 2015-04-04 23:32:12 UTC
sounds about right. works with fix?
Comment 11 Alex Xu (Hello71) 2015-04-04 23:34:06 UTC
Created attachment 400576 [details]
katawa-shoujo-1.3.ebuild

fixed question-mark, whitespace error. repoman clean.
Comment 12 Alex Xu (Hello71) 2015-04-05 14:59:47 UTC
Created attachment 400602 [details]
katawa-shoujo-1.3.ebuild
Comment 13 Alex Xu (Hello71) 2015-04-12 02:45:39 UTC
Created attachment 401062 [details]
katawa-shoujo-1.3.ebuild

games/proxy-maint, please review and commit.
Comment 14 Ian Delaney (RETIRED) gentoo-dev 2015-04-14 05:24:43 UTC
Length: 496193762 (473M) [application/x-bzip2]

Alex Xu, if no-one else does this for you (from games herd or proxy), I shall complete this and runtest.  I only baulk at the size of something I will only ever runtest to give your ebuild a confirmation. The ebuild looks good.
I am not saying no.
Comment 15 Alex Xu (Hello71) 2015-04-14 11:16:46 UTC
I considered this, but unfortunately there is no feasible way to reduce the size of the download, since there is a large data file that takes up most of the space, and the game will not run without it. If bandwidth is a serious issue, I am sure that of you give your OK to the ebuild, someone can runtest.
Comment 16 Pavel Volkov 2015-04-14 12:46:44 UTC
A question for the purposes of learning.
I put slotted renpy dependency and launch command with slotted renpy in my original ebuild since bundled renpy is 6.16.5. It was meant to minimize risk of things breaking as with the previous game version.
Why was it considered bad practice?
Comment 17 Ian Delaney (RETIRED) gentoo-dev 2015-04-15 12:32:22 UTC
*katawa-shoujo-1.3 (15 Apr 2015)

  15 Apr 2015; Ian Delaney <idella4@gentoo.org> +katawa-shoujo-1.3.ebuild:
  bump; ebuild by Alex Xu provided from bug #545504, builds and installs,
  runtested by maintainer