Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 545186 - www-client/qupzilla-1.8.6: fix LINGUAS support, add tests
Summary: www-client/qupzilla-1.8.6: fix LINGUAS support, add tests
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Qt Bug Alias
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-31 21:15 UTC by Nikoli
Modified: 2016-10-08 16:42 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
qupzilla-1.8.6.ebuild.patch (qupzilla-1.8.6.ebuild.patch,3.50 KB, patch)
2015-03-31 21:15 UTC, Nikoli
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikoli 2015-03-31 21:15:07 UTC
Created attachment 400302 [details, diff]
qupzilla-1.8.6.ebuild.patch

Attached patch fixes LINGUAS support:
1) l10n.eclass suggested differently sorted PLOCALES=
2) there were a lot lrelease messages about missing .ts files
3) plugins had internal .qm files, without them packages size is smaller: 8289525 -> 7580917 bytes


https://github.com/QupZilla/qupzilla/blob/v1.8/scripts/run_tests.sh

Tests need network. Benchmarks fail to build, so i did not enable them:
adblockmatchrule.cpp: In member function 'void AdBlockMatchRule::networkMatch()':
adblockmatchrule.cpp:65:55: error: 'class AdBlockSubscription' has no member named 'match'
             const AdBlockRule* rule = m_subscription->match(req, url.host(), url.toEncoded());
                                                       ^
Comment 1 Michael Palimaka (kensington) gentoo-dev 2016-10-08 16:42:12 UTC
We dropped custom linguas handling so I guess this is obsolete now.

Also regarding tests, we cannot enable tests that require network access.