Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 544716 - =sci-chemistry/p3d-0.4.3 request for conversion to new EAPI & eclass
Summary: =sci-chemistry/p3d-0.4.3 request for conversion to new EAPI & eclass
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Chemistry-Related Packages
URL:
Whiteboard:
Keywords: PATCH, TESTED
Depends on:
Blocks:
 
Reported: 2015-03-28 06:16 UTC by Ian Delaney (RETIRED)
Modified: 2017-02-17 22:35 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
diff -u patch of ebuilds (p3d.patch,1.08 KB, patch)
2015-03-28 06:16 UTC, Ian Delaney (RETIRED)
Details | Diff
diff -u patch of ebuilds (p3d.patch,1.05 KB, patch)
2015-03-28 06:25 UTC, Ian Delaney (RETIRED)
Details | Diff
diff -u patch of ebuilds (p3d.patch,1.08 KB, patch)
2015-03-31 00:50 UTC, Ian Delaney (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Delaney (RETIRED) gentoo-dev 2015-03-28 06:16:00 UTC
Created attachment 399914 [details, diff]
diff -u patch of ebuilds

p3d-0.4.3.ebuild inherit distutils and require conversion to the new eclass and EAPI upgrade. Patches to be committed if there is no response in 2 weeks.

I don't know what happened between the eclasses but 
S="${WORKDIR}"/fu-${PN}-9128134 was required in the conversion. Odd.

use examples is also odd, posing a new scenario I've rarely come across before.
There a 2 folders,  exampleScripts  pdbs, requiring putting into /usr/share/doc/${PF} however the eclass only accounts for 1.  We end up with

image//usr/share/doc/p3d-0.4.3-r1/examples/{exampleScripts,pdbs}

with the content of the 2nd., pdbs, still being compressed.

                local EXAMPLES=( pdbs/. )
                EXAMPLES+=( exampleScripts/. )

installs them all under 
image//usr/share/doc/p3d-0.4.3-r1/examples/.

which to me is all rather trivial.  There are a few other options but all are fiddly and inelegant.  Edit to your preference.

p3d-9999.ebuild will require all changes to be mirrored.
Comment 1 Ian Delaney (RETIRED) gentoo-dev 2015-03-28 06:25:00 UTC
Created attachment 399916 [details, diff]
diff -u patch of ebuilds

Noted src_prepare() is now redundant without 
 mv fu* ${P}
which doesn't work in new eclass.
Comment 2 Justin Lecher (RETIRED) gentoo-dev 2015-03-28 11:44:58 UTC
Comment on attachment 399916 [details, diff]
diff -u patch of ebuilds

> src_install() {
>-	distutils_src_install
> 	if use examples; then
>-		insinto /usr/share/${PN}
>-		doins -r pdbs exampleScripts || die
>+		local EXAMPLES=( pdbs )
>+		EXAMPLES+=( exampleScripts )
> 	fi
>+	distutils-r1_src_install
> }

This should be done in distutils-r1_python_install_all.
Comment 3 Ian Delaney (RETIRED) gentoo-dev 2015-03-31 00:50:21 UTC
Created attachment 400242 [details, diff]
diff -u patch of ebuilds

This should be done in distutils-r1_python_install_all.

distutils-r1_src_install merely calls distutils-r1_python_install_all. I could expand on this but I think it's neither warranted nor helpful.  Both yield the same result.

however
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2017-02-17 22:35:56 UTC
commit 9a64979f181d12d3b19c6a0d6f4edaf21a0c6e75
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: Fri Feb 17 23:31:52 2017
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: Fri Feb 17 23:33:08 2017

    sci-chemistry/p3d: distutils-r1, git-r3, EAPI=6