Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 544168 - net-fs/openafs-1.6.11: QA Notice: systemd units using /etc/conf.d detected:
Summary: net-fs/openafs-1.6.11: QA Notice: systemd units using /etc/conf.d detected:
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal QA (vote)
Assignee: Adam Feldman
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 570540
  Show dependency tree
 
Reported: 2015-03-22 22:18 UTC by Andrew Savchenko
Modified: 2016-03-25 04:57 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
This is a corrected/fixed systemd script. (openafs-client.service,475 bytes, text/plain)
2015-09-01 18:24 UTC, John F. Godfrey
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Savchenko gentoo-dev 2015-03-22 22:18:12 UTC
QA Notice: systemd units using /etc/conf.d detected:
usr/lib/systemd/system/openafs-client.service:EnvironmentFile=/etc/conf.d/openafs-client
usr/lib/systemd/system/openafs-server.service:EnvironmentFile=/etc/conf.d/openafs-server
See: https://wiki.gentoo.org/wiki/Project:Systemd/conf.d_files

$ eix -e openafs
[I] net-fs/openafs
     Available versions:  1.6.2-r1 1.6.5-r1 (~)1.6.11{tbz2}[1] {doc kerberos +modules pam}
     Installed versions:  1.6.11{tbz2}[1](11:22:27 PM 03/22/2015)(doc kerberos modules pam)
Comment 1 Ben Kohler gentoo-dev 2015-08-31 17:16:38 UTC
This appears to be more than just a minor QA problem. 

/etc/conf.d/openafs-client sets OPTIONS="AUTOMATIC", the openrc init script init.d/openafs-client detects this value and use it to set OPTIONS to a real value based on $SMALL $MEDIUM etc in /etc/conf.d/openafs-client.

But if I read these scripts correctly, on systemd the client service will literally try to launch "/usr/sbin/afsd AUTOMATIC"
Comment 2 John F. Godfrey 2015-09-01 18:24:34 UTC
Created attachment 410776 [details]
This is a corrected/fixed systemd script.

Thanks to iamben and grawity for their help!
Comment 3 Karol Krizka 2015-09-14 11:16:43 UTC
Does the attached systemd script use the settings defined in /etc/conf.d/openafs-client, or are they hard coded?
Comment 4 Ben Kohler gentoo-dev 2015-12-30 20:25:08 UTC
It doesn't use the settings from /etc/conf.d/openafs-client .  If you need to override ExecStart or something else, see item #5 here: https://wiki.gentoo.org/wiki/Project:Systemd/Ebuild_policy#Unit_file_guidelines

or the link given by Andrew in the original report
Comment 5 Adam Feldman gentoo-dev 2016-03-22 22:36:16 UTC
8e33d4b5d5506a291ddcd93e2d060c1b0b450d00 and f7b023652efe0fd358a9d2f75b785ba6a985632e updated systemd units.  Please test.
Comment 6 Adam Feldman gentoo-dev 2016-03-25 04:57:34 UTC
johnfg reports success with new systemd units.  Marking resolved.