Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 543776 - sys-power/apcupsd-3.14.13: ebuild enhancement request
Summary: sys-power/apcupsd-3.14.13: ebuild enhancement request
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: John Einar Reitan
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-19 10:24 UTC by David Flogeras
Modified: 2018-05-01 08:15 UTC (History)
7 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild for 3.14.13 (apcupsd-3.14.13.ebuild,3.93 KB, text/plain)
2015-11-14 02:25 UTC, Joe M
Details
patch to add powerfail init script to upstream package (apcupsd-3.14.13-added-powerfail.patch,1.70 KB, patch)
2015-11-14 02:25 UTC, Joe M
Details | Diff
/etc/init.d/apcupsd-powerfail script (apcupsd-powerfail.init.in,435 bytes, text/plain)
2015-11-14 02:26 UTC, Joe M
Details
/etc/init.d/apcupsd script templlate (apcupsd.init.in,1.19 KB, text/plain)
2015-11-14 02:26 UTC, Joe M
Details
ebuild for 3.14.13 (apcupsd-3.14.13.ebuild,3.93 KB, text/plain)
2017-05-01 19:23 UTC, Joe M
Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Flogeras 2015-03-19 10:24:22 UTC
The new release includes a fix for #515526.

Reproducible: Always
Comment 1 James Chew 2015-06-16 15:30:02 UTC
Would like to bump this request...
Comment 2 Joe M 2015-11-14 02:25:09 UTC
Created attachment 416890 [details]
ebuild for 3.14.13
Comment 3 Joe M 2015-11-14 02:25:49 UTC
Created attachment 416892 [details, diff]
patch to add powerfail init script to upstream package
Comment 4 Joe M 2015-11-14 02:26:20 UTC
Created attachment 416894 [details]
/etc/init.d/apcupsd-powerfail script
Comment 5 Joe M 2015-11-14 02:26:55 UTC
Created attachment 416896 [details]
/etc/init.d/apcupsd script templlate
Comment 6 Joe M 2015-11-14 02:28:49 UTC
With this ebuild, I changed apcupsd.powerfail to apcupsd-powerfail, to avoid confusing this script with the script names of multiple apcupsd instances.
Comment 7 Joe M 2015-11-14 02:51:42 UTC
Changes in this ebuild:


1. changed apcupsd.powerfail to apcupsd-powerfail, to avoid confusing this script with the script names of multiple apcupsd instances.
2. changed EAPI to 5
3. removed || die commands after eutils
4. used upstream mechanism to generate /etc/init.d/{apcupsd,apcupsd-powerfail} to avoid having to hardcode piddir, powerfaildir, sysconfdir, etc.
5. use the apcupsd.conf of the upstream package. That appears saner than the one packaged in the files/.
6. nisip defaulted to 127.0.0.1 instead of leaving it at 0.0.0.0
7. removed the configure argument for nis-port, as it defaults to 3551 anyway.
8. changed default --with-pwrfail-dir to /run/apcupsd from /etc/apcupsd, to help in situations where /etc is read-only.

ebuild also here:
https://github.com/joe9/portage/blob/master/sys-power/apcupsd/apcupsd-3.14.13.ebuild
Comment 8 Lars Wendler (Polynomial-C) gentoo-dev 2015-12-22 12:15:47 UTC
commit d2f026a3480457d00c8e6f8acfc4431892275dad
Author: Lars Wendler <polynomial-c@gentoo.org>
Date:   Tue Dec 22 13:04:17 2015

    sys-power/apcupsd: Bump to version 3.14.13

    Package-Manager: portage-2.2.26
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>


Unfortunately I missed your proposed changes. But to be honest incorporating them is more the topic of Matthew and thus I keep the bug open for him to maybe add a revbumped version of 3.14.13
Comment 9 Matt Whitlock 2017-04-01 08:59:53 UTC
(In reply to Joe M from comment #7)

Would you please also change APCUPSD_MAIL from /bin/mail to /usr/bin/mail? The former no longer exists in current version of mail-client/mailx.
Comment 10 Joe M 2017-05-01 19:23:14 UTC
Created attachment 471470 [details]
ebuild for 3.14.13

Updated the APCUPSD_MAIL from /bin/mail to /usr/bin/mail
Comment 11 Joe M 2017-05-01 19:25:27 UTC
(In reply to Matt Whitlock from comment #9)
> (In reply to Joe M from comment #7)
> 
> Would you please also change APCUPSD_MAIL from /bin/mail to /usr/bin/mail?
> The former no longer exists in current version of mail-client/mailx.

Updatedd the ebuild with the above change to /usr/bin/mail.

Thanks