Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 541964 - =media-video/{tovid-0.34_p20120123,winki-0.4.5} request conversion to distutils-r1 eclass
Summary: =media-video/{tovid-0.34_p20120123,winki-0.4.5} request conversion to distuti...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Deadline: 2015-03-17
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords: PATCH
: 315069 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-03-03 07:49 UTC by Ian Delaney (RETIRED)
Modified: 2015-06-09 01:56 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
diff -u patch of tovid ebuilds (tovid.patch,1.47 KB, patch)
2015-03-03 07:49 UTC, Ian Delaney (RETIRED)
Details | Diff
diff -u patch of winki ebuilds (winki.patch,1.22 KB, patch)
2015-03-03 07:49 UTC, Ian Delaney (RETIRED)
Details | Diff
tovid diff to tovid-0.34_p20120123.ebuild (tovid.diff,2.02 KB, patch)
2015-04-03 22:23 UTC, grepper
Details | Diff
possible tovid-git ebuild from a non maintainer -use as desired (tovid-git-9999.ebuild,1.19 KB, text/plain)
2015-04-03 22:36 UTC, grepper
Details
tovid updated to 0.35.2: New SRC_URI and version bump (tovid.diff,435 bytes, patch)
2015-06-03 15:16 UTC, grepper
Details | Diff
tovid pkg_postinst improvemets (tovid.diff,850 bytes, patch)
2015-06-06 09:49 UTC, BT
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Delaney (RETIRED) gentoo-dev 2015-03-03 07:49:02 UTC
Created attachment 397918 [details, diff]
diff -u patch of tovid ebuilds

media-video/tovid ebuilds inherit distutils and require conversion to the new eclass and EAPI upgrade. Patches to be committed if there is no response in 2 weeks."

tovid-0.34.ebuild has been stabled. 0.34_p20120123-r1 will require stabling then 0.34 & 0.34_p20120123 may be purged.

winki-0.4.5 has been stabled. winki-0.4.5-r1 will require stabling then winki-0.4.5 may be purged.
Comment 1 Ian Delaney (RETIRED) gentoo-dev 2015-03-03 07:49:55 UTC
Created attachment 397920 [details, diff]
diff -u patch of winki ebuilds
Comment 2 grepper 2015-04-03 22:23:31 UTC
Created attachment 400502 [details, diff]
tovid diff to tovid-0.34_p20120123.ebuild

Tovid has moved to Github, hence the URL has changed. Here is a diff to the original ebuild, with some corrections to the depends. I am NOT a gentoo packager but am a tovid developer.
pycairo and vcdimager are not needed, and tovid can use ffmpeg OR libav (ffmpeg suggested) and mplayer OR mpv (mplayer suggested). Indeed mplayer2 will work as well but I didn't want to complicate things.

I have added an attachment which can be used as desired. I have also attached an ebuild that can be used with latest git, but I don't know the policy regarding such. Again, use as desired.

grepper
Comment 3 grepper 2015-04-03 22:36:42 UTC
Created attachment 400506 [details]
possible tovid-git ebuild from a non maintainer -use as desired

This ebuild uses the new Github repo to do a git clone.
Comment 4 Ian Delaney (RETIRED) gentoo-dev 2015-04-04 14:25:24 UTC
grepper, thx
Initially I had set 17-03 as a timeout date however it's just as well I missed it.  Nice addition having a tovid dev pitch in.  In case you actually read this, libav has become a villain and is more or less being purged or deprecated as an option.  I shall give this a few more days and commit based on your first patch.
Comment 5 grepper 2015-04-06 02:40:16 UTC
Great, thanks Ian. I should mention that though I removed transcode from the dependencies in that diff, it is in fact an OPTIONAL dependency. If it is present it will be used, and will speed up seeking in some use cases like animated submenus because of its navigation log feature. I didn't know how to indicate an optional dependency. If one were to just use the pkg_postinst() as I see suggested elsewhere, it would look something like:

pkg_postinst() {
    einfo
    einfo "######################################################################"
    einfo "You can install transcode for additional functionality - it will "
    einfo "speed up the creation of animated submenus with faster seeking."
    einfo "Other wise ffmpeg will be used."
    einfo "######################################################################"
    einfo
    gnome2_icon_cache_update
}

But again, I know nothing of packaging :)

cheers,
Robert
Comment 6 Ian Delaney (RETIRED) gentoo-dev 2015-04-06 04:53:39 UTC
grepper

there are a couple of ways of doing it. That works just fine. Seeing your not looking to learn ebuild writing as a craft I won't outline the alternatives.  It's only Easter Monday I'll leave it a little longer.
Comment 7 Pacho Ramos gentoo-dev 2015-06-03 10:57:21 UTC
*** Bug 315069 has been marked as a duplicate of this bug. ***
Comment 8 grepper 2015-06-03 15:16:29 UTC
Created attachment 404522 [details, diff]
tovid updated to 0.35.2: New SRC_URI and version bump

tovid has been updated to tovid-0.35.2. Diff to tovid-0.35.0.ebuild.
List of changes here:
https://github.com/tovid-suite/tovid/releases/tag/0.35.2

cheers,
Robert
Comment 9 Ian Delaney (RETIRED) gentoo-dev 2015-06-06 06:35:49 UTC
(In reply to grepper from comment #8)
> Created attachment 404522 [details, diff] [details, diff]
> tovid updated to 0.35.2: New SRC_URI and version bump
> 
> tovid has been updated to tovid-0.35.2. Diff to tovid-0.35.0.ebuild.
> List of changes here:
> https://github.com/tovid-suite/tovid/releases/tag/0.35.2
> 
> cheers,
> Robert

Sadly there are a few aspects here tangling the whole issue
The use of eclass git-r3 and its associated vars EGIT_.... are used in live ebuilds which is name with a -9999.ebuild, a very different 'creature'. The bump to the 0.35.2 is again a 'versioned' ebuild so these are not required.
The line I cannot grasp is !=media-video/tovid-0*. In portage this is quite redundant.  A 'blocker' is used on packages that compete or collide with the ebuilded package. It isn't used to block against itself.

There are a few other ways of doing this but this form appears to work. I suggest you runtest it and report back accordingly.

*tovid-0.35.2 (06 Jun 2015)

  06 Jun 2015; Ian Delaney <idella4@gentoo.org> +tovid-0.35.2.ebuild:
  bump; ebuild based on submission by the upsrteam author of tovid from bug
  #541964; converted to distutils-r1 and deps edited by author
Comment 10 BT 2015-06-06 09:49:45 UTC
Created attachment 404662 [details, diff]
tovid pkg_postinst improvemets

Thank you for the tovid 0.35.2 ebuild. I have provided a patch to improve the pkg_postinst message slightly. It specifies the full category/package for transcode and changes 'Other wise' to one word.
Comment 11 grepper 2015-06-06 14:32:40 UTC
@Ian Delaney

I removed the  !=media-video/tovid-0* line. The ebuild runs without errors and the tovid program works fine in some basic tests I did. I'm not sure what else you want me to do at this point for as you know I am not a gentoo packager (or user for that matter) and don't really have the expertise to refine it further.
Comment 12 Ian Delaney (RETIRED) gentoo-dev 2015-06-09 01:56:26 UTC
(In reply to grepper from comment #11)

> I'm not sure what else you want me to do at this point for as you know I am
> not a gentoo packager (or user for that matter) and don't really have the
> expertise to refine it further.

Nothing further. Your effort here is appreciated in large doses. Thank you.

If you wish to proxy maintain it you're welcome. I can provide the first hand support to get you equipped in the required ebuild writing skills and commit on your behalf.

(In reply to BT from comment #10)

> I have provided a patch to improve the pkg_postinst message slightly. It
> specifies the full category/package for transcode and changes 'Other wise' to
> one word.

Thx

  09 Jun 2015; Ian Delaney <idella4@gentoo.org> tovid-0.35.2.ebuild:
  tidy to msg output in pkg_postins provided by "BT" in bug #541964

*winki-0.4.5-r1 (09 Jun 2015)

  09 Jun 2015; Ian Delaney <idella4@gentoo.org> +winki-0.4.5-r1.ebuild:
  revbump to distutils-r1, fixes bug #541964