Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 541958 - =net-libs/rb_libtorrent-0.16.17-r1 request conversion to inherit python-r1
Summary: =net-libs/rb_libtorrent-0.16.17-r1 request conversion to inherit python-r1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Markos Chandras (RETIRED)
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2015-03-03 04:17 UTC by Ian Delaney (RETIRED)
Modified: 2015-03-05 15:31 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
diff -u patch (rb_libtorrent.patch,3.05 KB, patch)
2015-03-03 04:17 UTC, Ian Delaney (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Delaney (RETIRED) gentoo-dev 2015-03-03 04:17:12 UTC
Created attachment 397916 [details, diff]
diff -u patch

rb_libtorrent-1.0.[2-3].ebuild have been converted but are pmasked due to the issue of Bug 539368. There is no indication re a time frame for this to be fixed.
rb_libtorrent has rdeps that require it to need available versions converted to the new eclass.  This makes a need for rb_libtorrent-0.16.17-r1.ebuild to be converted to satisfy them. One example is media-video/miro.

Patch is modeled from 
~/cvsPortage/gentoo-x86/net-libs/rb_libtorrent $ USE=pythyon ebuild rb_libtorrent-0.16.17-r2.ebuild clean compile install

completes fine with ebuilds of rb_libtorrent-1.  Best to be further run tested.

* QA Notice: Package triggers severe warnings which indicate that it
 *            may exhibit random runtime failures.
 * entry.cpp:193:46: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
(more)
 * file.cpp:1901:29: warning: array subscript is above array bounds [-Warray-bounds]
 * file.cpp:1908:32: warning: array subscript is above array bounds [-Warray-bounds]
 * file.cpp:1908:80: warning: array subscript is above array bounds [-Warray-bounds]

Tried a number of known methods to rid this but didn't succeed. Possiblty re-sets during the build.

rb_libtorrent-0.16.17-r2.ebuild will need making sable to allow purging of old.
Comment 1 Markos Chandras (RETIRED) gentoo-dev 2015-03-03 22:16:13 UTC
The patch is very python specific and I don't have all the required knowledge to review it. So I am fine if you commit this is as separate revbump and let it be tested by ~testing users. You might also get some conflicts because of bug #541690 but it should be easy to resolve them.
Comment 2 Ian Delaney (RETIRED) gentoo-dev 2015-03-05 15:31:30 UTC
(In reply to Markos Chandras from comment #1)
> The patch is very python specific and I don't have all the required
> knowledge to review it. So I am fine if you commit this is as separate
> revbump and let it be tested by ~testing users. You might also get some
> conflicts because of bug #541690 but it should be easy to resolve them.

These don't appear to pose a problem. Just adjusted patch to match change of deps in rb_libtorrent-0.16.17-r1.ebuild  03 Mar 2015;
By rights b_libtorrent-0.16.17-r1.ebuild can now be purged but the new revbump should have time for ~users to test and better for you to purge it.
The edited patch tests fine and should have no major flaws, but that can become apparent with ~users to test.

 * QA Notices were there to begin with and I couldn't make either disappear.

*rb_libtorrent-0.16.17-r2.ebuild (05 Mar 2015)

  05 Mar 2015; Ian Delaney <idella4@gentoo.org>
  +rb_libtorrent-0.16.17-r2.ebuild:
  revbump; conversion to python-r1 modelled on conversions of
  rb_libtorrent-1*, consent by maintainer provided in Bug 541958,
  fixes said bug

Thanks Markos