Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 54179 - mozilla-firefox and -bin ebuilds create GNOME/KDE menu entries incorrectly
Summary: mozilla-firefox and -bin ebuilds create GNOME/KDE menu entries incorrectly
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-06-17 01:34 UTC by Keith Lea
Modified: 2004-06-18 10:52 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
patch for mozilla-firefox-0.9-r1.ebuild (firefox-patch.txt,589 bytes, patch)
2004-06-17 01:36 UTC, Keith Lea
Details | Diff
patch for mozilla-firefox-bin-0.9-r1.ebuild (firefox-patch-2.txt,490 bytes, patch)
2004-06-17 01:38 UTC, Keith Lea
Details | Diff
A new net-www/mozilla-firefox-bin/files/icon/mozillafirefox-bin.desktop (mozillafirefox-bin.desktop,163 bytes, text/plain)
2004-06-17 01:39 UTC, Keith Lea
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Lea 2004-06-17 01:34:54 UTC
The mozilla-firefox ebuilds should create menu entries (those .desktop files) in /usr/share/applications, not in GNOME-specific folders.

Additionally, mozilla-firefox-bin's menu entry should be "Mozilla Firefox", not "Mozilla Firefox (bin)". In fact, mozilla-firefox-bin should use the same .desktop file that mozilla-firefox uses.

I have attached a new .desktop file and updated ebuilds to correct these problems.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Keith Lea 2004-06-17 01:36:05 UTC
Created attachment 33412 [details, diff]
patch for mozilla-firefox-0.9-r1.ebuild
Comment 2 Keith Lea 2004-06-17 01:38:46 UTC
Created attachment 33413 [details, diff]
patch for mozilla-firefox-bin-0.9-r1.ebuild
Comment 3 Keith Lea 2004-06-17 01:39:31 UTC
Created attachment 33414 [details]
A new net-www/mozilla-firefox-bin/files/icon/mozillafirefox-bin.desktop
Comment 4 Aron Griffis (RETIRED) gentoo-dev 2004-06-18 04:46:19 UTC
Keith, it's possible these days on Gentoo to install both firefox and firefox-bin simultaneously, so we need the separate menu entries.  Regarding the location for the menu entries, I'll get that fixed up, thanks.
Comment 5 Aron Griffis (RETIRED) gentoo-dev 2004-06-18 07:59:51 UTC
ok, all fixed.  I didn't bother to bump the revisions for this change since it's still ~arch anyway, so I don't see the need to make all testers rebuild.  Thanks!
Comment 6 Keith Lea 2004-06-18 10:52:55 UTC
I think very few people install mozilla-firefox and mozilla-firefox-bin. I think adding the "(bin)" to the end of "Mozilla Firefox" to make these few people happy at the expense of annoying 99% of users is not the right way to do this.

Two menu items can have the same name; they could both be "Mozilla Firefox", and one could have a tooltip that said "(precompiled)" at the end of it (in the Comment field of the .desktop entry).