Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 541390 - dev-python/cangjie-1.2 version bump
Summary: dev-python/cangjie-1.2 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Brendan Horan
URL:
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2015-02-26 02:40 UTC by Brendan Horan
Modified: 2015-03-02 06:52 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
cangjie-1.2.ebuild (cangjie-1.2.ebuild,877 bytes, text/plain)
2015-02-26 02:43 UTC, Brendan Horan
Details
full build log (build.log.xz,2.95 KB, application/x-xz)
2015-02-28 07:37 UTC, Yixun Lan
Details
cangjie-1.2-cython-022.patch (cangjie-1.2-cython-022.patch,1.13 KB, patch)
2015-03-02 05:58 UTC, Brendan Horan
Details | Diff
cangjie-1.2.ebuild (cangjie-1.2.ebuild,940 bytes, text/plain)
2015-03-02 05:58 UTC, Brendan Horan
Details
cangjie-1.2.ebuild (cangjie-1.2.ebuild,947 bytes, text/plain)
2015-03-02 06:20 UTC, Brendan Horan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Brendan Horan 2015-02-26 02:40:01 UTC
Upstream has released v1.3.
New download source location as well, required update to ebuild 

Reproducible: Always
Comment 1 Brendan Horan 2015-02-26 02:43:27 UTC
Created attachment 397532 [details]
cangjie-1.2.ebuild

SRC_URI changed and version bump to 1.2
REPOMAN checks passed.
Comment 2 Brendan Horan 2015-02-26 02:45:41 UTC
Typo in first comment, version is 1.2.
Comment 3 Yixun Lan archtester gentoo-dev 2015-02-28 07:37:01 UTC
Created attachment 397642 [details]
full build log

build fail here

# GNU Lesser General Public License for more details.
#
# You should have received a copy of the GNU Lesser General Public License
# along with pycangjie.  If not, see <http://www.gnu.org/licenses/>.

cimport _core
       ^
------------------------------------------------------------

/var/tmp/portage/dev-python/cangjie-1.2/work/cangjie-1.2/src/cangjie/filters.pyx:18:8: '_core.pxd' not found
Makefile:1362: recipe for target 'src/cangjie/filters.c' failed
make[1]: *** [src/cangjie/filters.c] Error 1
make[1]: *** Waiting for unfinished jobs....
Compiling /var/tmp/portage/dev-python/cangjie-1.2/work/cangjie-1.2/src/cangjie/versions.pyx

Error compiling Cython file:
Comment 4 Brendan Horan 2015-03-02 02:39:37 UTC
I may be reading the build log wrong but it seems your using cython 0.22 ?

From the attached build log:
"checking for cython version... 0.22"

That version is still masked as unstable(~) ?
http://packages.gentoo.org/package/dev-python/cython


On my machines I am using 0.21.1 :
"checking for cython version... 0.21.1"

This is the current stable version and the build succeeds.

Could this be why ?
Comment 5 Yixun Lan archtester gentoo-dev 2015-03-02 03:21:08 UTC
(In reply to Brendan Horan from comment #4)
> I may be reading the build log wrong but it seems your using cython 0.22 ?
> 
> From the attached build log:
> "checking for cython version... 0.22"
..
> 
> This is the current stable version and the build succeeds.
> 
> Could this be why ?

yes, cython-0.22 installed here, and I've tested with 0.21.2, it works fine.

do you have a patch to fix this in cangjie? or possible report to upstream
or do you prefer to adjust the dep[1] ?


[1] patch to fix the dependency

--- a/cangjie-1.2.ebuild
+++ b/cangjie-1.2.ebuild
@@ -17,8 +17,7 @@ KEYWORDS="~amd64 ~x86"
 
 DEPEND="${PYTHON_DEPS}
        app-i18n/libcangjie
-       dev-python/cython
-       >=dev-python/cython-0.14"
+       <dev-python/cython-0.22"
Comment 6 Brendan Horan 2015-03-02 05:33:56 UTC
(In reply to Yixun Lan from comment #5)

> do you have a patch to fix this in cangjie? or possible report to upstream
> or do you prefer to adjust the dep[1] ?
> 
> 
> [1] patch to fix the dependency
> 
> --- a/cangjie-1.2.ebuild
> +++ b/cangjie-1.2.ebuild
> @@ -17,8 +17,7 @@ KEYWORDS="~amd64 ~x86"
>  
>  DEPEND="${PYTHON_DEPS}
>         app-i18n/libcangjie
> -       dev-python/cython
> -       >=dev-python/cython-0.14"
> +       <dev-python/cython-0.22"

I would rather adjust the dependence.
Comment 7 Brendan Horan 2015-03-02 05:38:06 UTC
Hold up, upstream may have a patch. Will test
Comment 8 Brendan Horan 2015-03-02 05:58:09 UTC
Created attachment 397834 [details, diff]
cangjie-1.2-cython-022.patch

Patch from upstream to fix the cython 0.22 building issues.
Comment 9 Brendan Horan 2015-03-02 05:58:41 UTC
Created attachment 397836 [details]
cangjie-1.2.ebuild

New ebuild to include the patch from upstream.
Comment 10 Brendan Horan 2015-03-02 06:05:13 UTC
Yixun Lan, can you test this patch?

I don't have machines with 0.22 cython running.

Thanks
Comment 11 Brendan Horan 2015-03-02 06:20:05 UTC
Created attachment 397838 [details]
cangjie-1.2.ebuild
Comment 12 Yixun Lan archtester gentoo-dev 2015-03-02 06:52:00 UTC
+*cangjie-1.2 (01 Mar 2015)
+
+  01 Mar 2015; Yixun Lan <dlan@gentoo.org> +cangjie-1.2.ebuild,
+  +files/cangjie-1.2-cython-022.patch, metadata.xml:
+  version bump, bug 541390, fix cython-0.22 err, thanks Brendan Horan

patch works and accepted, thanks