Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 540034 - sys-process/numactl: convert to multilib
Summary: sys-process/numactl: convert to multilib
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords: Inclusion, PATCH
Depends on:
Blocks: 510180 540036
  Show dependency tree
 
Reported: 2015-02-14 04:56 UTC by Christoph Junghans
Modified: 2015-02-20 02:48 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch against gx86 (numactl-2.0.10-r1.ebuild.patch,854 bytes, patch)
2015-02-14 04:56 UTC, Christoph Junghans
Details | Diff
patch against gx86 (numactl-2.0.10-r1.ebuild.patch2,1.02 KB, patch)
2015-02-16 22:58 UTC, Christoph Junghans
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Junghans gentoo-dev 2015-02-14 04:56:07 UTC
Created attachment 396420 [details, diff]
patch against gx86

sys-process/numactl is a dependency of sys-apps/hwloc, which is needed for sys-cluster/openmpi (bug #519700).

Changes:
- inherit multilib-minimal
- set ECONF_SOURCE=${S}
- reworked src_install into multilib_src_install_all
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2015-02-14 08:00:01 UTC
Looks fine.
Comment 2 Christoph Junghans gentoo-dev 2015-02-16 02:35:37 UTC
@base-system: please review
Comment 3 SpanKY gentoo-dev 2015-02-16 04:32:40 UTC
(In reply to Christoph Junghans from comment #0)

numactl is more than a library.  you shouldn't waste time building the tools for other ABIs when they aren't used.
Comment 4 Christoph Junghans gentoo-dev 2015-02-16 06:55:07 UTC
(In reply to SpanKY from comment #3)
> (In reply to Christoph Junghans from comment #0)
> 
> numactl is more than a library.  you shouldn't waste time building the tools
> for other ABIs when they aren't used.
Sure, but on my machine the compile time difference is minimal, "make -j1 all" took 7.3s while "make -j1 libnuma.la" took 3.5s. In addition the compile part is only a small of the whole merge. So is it worth the hazzle?

Technically the solution could be:
multilib_src_compile() {
multilib_is_native_abi && default || emake libnuma.la
}
and
multilib_src_install() {
multilib_is_native_abi && emake DESTDIR="${D}" install  || emake DESTDIR="${D}" install-libLTLIBRARIES
}

Anyhow, your ebuild, your call!
Comment 5 Christoph Junghans gentoo-dev 2015-02-16 22:58:30 UTC
Created attachment 396638 [details, diff]
patch against gx86

Updated version of the patch to save compile time.
Comment 6 Christoph Junghans gentoo-dev 2015-02-18 19:10:58 UTC
@vapier: which version do you prefer, the simple or time-saving one?
Comment 7 SpanKY gentoo-dev 2015-02-19 19:16:03 UTC
i've fine with the new more complicated version.  not everyone has fast machines, so i'd rather elide the compilation entirely.
Comment 8 Christoph Junghans gentoo-dev 2015-02-20 02:48:07 UTC
+*numactl-2.0.10-r1 (20 Feb 2015)
+
+  20 Feb 2015; Christoph Junghans <ottxor@gentoo.org> +numactl-2.0.10-r1.ebuild:
+  added multilib support (bug #540034)
+