Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 539996 - perl-core/ExtUtils-MakeMaker should possibly employ "$ENV{BUILDING_AS_PACKAGE}"
Summary: perl-core/ExtUtils-MakeMaker should possibly employ "$ENV{BUILDING_AS_PACKAGE}"
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Perl team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 541544
  Show dependency tree
 
Reported: 2015-02-13 17:20 UTC by Kent Fredric (IRC: kent\n) (RETIRED)
Modified: 2015-02-27 23:46 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2015-02-13 17:20:09 UTC
This is a minor concern because most people won't be installing it due to the virtual defaulting to perl. Its just something we should look into doing as it looks more sensible than what we're currently doing.

So I'm just sticking this here so It doesn't get forgotten.

EUMM's own Makefile.PL has various code in it intended to be used for "bootstrap" purposes that we don't need to activate, and we're presently letting it trigger and then nuking bundled code after the fact.

But it appears EUMM has ( since at least version 6.6 ) supported setting an ENV var "BUILDING_AS_PACKAGE" which turns it back into assuming it can be installed like a normal module, and this also disables bundling mechanics.


Its clear this feature exists *for* vendors like us, so we may as well use it.

https://metacpan.org/source/BINGOS/ExtUtils-MakeMaker-7.05_12/Makefile.PL#L21

https://metacpan.org/source/BINGOS/ExtUtils-MakeMaker-7.05_12/Makefile.PL#L48

And here is the line of code that does the bundled stuff that we'd be avoiding: https://metacpan.org/source/BINGOS/ExtUtils-MakeMaker-7.05_12/Makefile.PL#L78 


Benefits include: 

1. Potentially warning us about incompatible module scenarios that have been triggered by our avoidance of bundling

2. Running EUMMs own code and test suites against our vendor-provided versions instead of the bundled ones, helping further be assured that it can be expected to work after installation.

3. Eliminating some of the redundant code wrapping in src_install
Comment 1 Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2015-02-27 17:54:20 UTC
Also, as articled in bug #541544, "Delete it if its not ExtUtils" is not sufficient for detecting Bundled things.

Because ExtUtils::MakeMaker bundles ExtUtils::Manifest!
Comment 2 Andreas K. Hüttel archtester gentoo-dev 2015-02-27 23:46:21 UTC
  27 Feb 2015; Andreas K. Huettel <dilfridge@gentoo.org>
  +ExtUtils-MakeMaker-7.40.0-r1.ebuild:
  Fix bug 539996 and bug 541544