Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 539712 - =app-emulation/virtualbox-bin-4.3.20.96996 revbump request
Summary: =app-emulation/virtualbox-bin-4.3.20.96996 revbump request
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Deadline: 2015-03-11
Assignee: Lars Wendler (Polynomial-C) (RETIRED)
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2015-02-11 04:39 UTC by Ian Delaney (RETIRED)
Modified: 2015-04-07 10:23 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
diff -u between current and a would be -r1 (virtualbox-bin.patch,720 bytes, patch)
2015-02-11 04:39 UTC, Ian Delaney (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Delaney (RETIRED) gentoo-dev 2015-02-11 04:39:08 UTC
Created attachment 396166 [details, diff]
diff -u between current and a would be -r1

In pursuit of upgrading python eclasses this package came up in a list requiring upgrade.  The ebuild currently doesn't inherit a python eclass at all however it qualifies to do so.  The patch included here covers basic content required and passes by use of 

# portageq metadata / ebuild app-emulation/virtualbox-bin-4.3.20.96996-r1::gentoo
remembering I made an -r1 for the purpose.  The revbump will also require attention to the following code.

local pyslot
for pyslot in 2.7 ; do
            if has_version "dev-lang/python:${pyslot}" && [ -f "${S}/VBoxPython${pyslot/./_}.so" ] ; then
                        doins VBoxPython${pyslot/./_}.so

since it will no longer be pertinent.
Comment 1 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2015-04-01 13:07:14 UTC
Feel free to add the revbumps with your suggested changes. Please make sure you don't break python stuff.
Comment 2 Ian Delaney (RETIRED) gentoo-dev 2015-04-02 13:43:26 UTC
(In reply to Lars Wendler (Polynomial-C) from comment #1)
> Feel free to add the revbumps with your suggested changes. Please make sure
> you don't break python stuff.

Well, I can but try.  I am known for being trying.

Speaking of trying;

  17 Mar 2015; Lars Wendler <polynomial-c@gentoo.org>
  -virtualbox-bin-4.3.20.96996.ebuild, +virtualbox-bin-4.3.26.98988.ebuild:

6 days after I submitted this bug.

*virtualbox-bin-4.3.26.98988-r1 (02 Apr 2015)

  02 Apr 2015; Ian Delaney <idella4@gentoo.org>
  +virtualbox-bin-4.3.26.98988-r1.ebuild:
  revbump; add python-r1 eclass to conduct install with use of python use flag,
  fixes bug #539712 with consent of maintainer.

While there are numerous old ebuilds, none have old EAPI values nor inherit an olde eclass.  This runtests fine with USE=python.
Comment 3 Arfrever Frehtes Taifersar Arahesis 2015-04-06 18:20:51 UTC
Since installation of Python-related files is conditional on "python" USE flag, this USE flag should be respected in dependencies and REQUIRED_USE:

--- virtualbox-bin-4.3.26.98988-r1.ebuild
+++ virtualbox-bin-4.3.26.98988-r1.ebuild
@@ -77,5 +77,5 @@
        x11-libs/libXdmcp
-       ${PYTHON_DEPS}"
+       python? ( ${PYTHON_DEPS} )"
 
-REQUIRED_USE="${PYTHON_REQUIRED_USE}"
+REQUIRED_USE="python? ( ${PYTHON_REQUIRED_USE} )"
 S=${WORKDIR}
Comment 4 Ian Delaney (RETIRED) gentoo-dev 2015-04-07 10:23:40 UTC
  07 Apr 2015; Ian Delaney <idella4@gentoo.org>
  virtualbox-bin-4.3.26.98988-r1.ebuild:
  correction to revbump wrt Bug #539712

*virtualbox-bin-4.3.26.98988-r1 (02 Apr 2015)