Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 538948 - media-libs/imlib2-1.4.6-r2 with media-libs/giflib-5.1.1 - .../work/imlib-1.9.15/Imlib/load.c:457:3: error: too few arguments to function ‘DGifOpenFileHandle’
Summary: media-libs/imlib2-1.4.6-r2 with media-libs/giflib-5.1.1 - .../work/imlib-1.9....
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Graphics Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: giflib-5
  Show dependency tree
 
Reported: 2015-02-05 17:53 UTC by Andrew John Hughes
Modified: 2015-05-11 16:32 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
imlib2-fix_compilation_with_giflib-5.1.x.patch (imlib2-fix_compilation_with_giflib-5.1.x.patch,2.81 KB, patch)
2015-05-11 13:45 UTC, Paolo Pedroni 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew John Hughes 2015-02-05 17:53:49 UTC 
5.1.x changed the signature of DGifCloseFile to take the address of an integer for the error code.

Reproducible: Always

Steps to Reproduce:
1. Install giflib 5.1.1.
2. Try to build imlib2 1.4.6-r2
3.
Actual Results:  
Fails

Expected Results:  
Succeeds

Portage 2.2.15 (python 2.7.8-final-0, hardened/linux/amd64, gcc-4.9.1, glibc-2.20, 3.18.4-hardened.rivendell x86_64)
=================================================================
System uname: Linux-3.18.4-hardened.rivendell-x86_64-Intel-R-_Xeon-R-_CPU_X5482_@_3.20GHz-with-gentoo-2.2
KiB Mem:     8216292 total,    784424 free
KiB Swap:    6147416 total,   5825932 free
Timestamp of tree: Thu, 05 Feb 2015 07:15:01 +0000
sh bash 4.3_p30-r1
ld GNU gold (Gentoo 2.24 p1.4 2.24) 1.11
app-shells/bash:          4.3_p30-r1
dev-java/java-config:     2.2.0
dev-lang/perl:            5.20.1-r3
dev-lang/python:          2.7.8, 3.4.2
dev-util/cmake:           3.1.0
dev-util/pkgconfig:       0.28-r2
sys-apps/baselayout:      2.2
sys-apps/openrc:          0.13.8
sys-apps/sandbox:         2.6-r1
sys-devel/autoconf:       2.13, 2.69
sys-devel/automake:       1.9.6-r4, 1.10.3-r1, 1.11.6-r1, 1.12.6, 1.13.4, 1.14.1
sys-devel/binutils:       2.24-r3
sys-devel/gcc:            4.8.2, 4.9.1
sys-devel/gcc-config:     1.8
sys-devel/libtool:        2.4.4
sys-devel/make:           4.1-r1
sys-kernel/linux-headers: 3.17-r1 (virtual/os-headers)
sys-libs/glibc:           2.20
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2015-02-06 09:26:17 UTC 
Please attach the entire build log to this bug report.
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2015-02-06 09:30:22 UTC 

*** This bug has been marked as a duplicate of bug 538976 ***
Comment 4 Paolo Pedroni 2015-05-11 13:45:28 UTC 
(In reply to Andrew John Hughes from comment #1)
> Fix is:
> 
> http://git.enlightenment.org/legacy/imlib2.git/commit/
> ?id=540df42aab3b6aa1a5b774a02769758cf5b9b404

Are you sure about this fix? It does not apply to media-libs/imlib2-1.4.6-r2.

I will attach one that applies and compile (and hopefully works ;-) )
Comment 5 Paolo Pedroni 2015-05-11 13:45:54 UTC 
Created attachment 403038 [details, diff]
imlib2-fix_compilation_with_giflib-5.1.x.patch

This apparently works...
Comment 6 Paolo Pedroni 2015-05-11 15:04:15 UTC 
(In reply to Andrew John Hughes from comment #1)
> Fix is:
> 
> http://git.enlightenment.org/legacy/imlib2.git/commit/
> ?id=540df42aab3b6aa1a5b774a02769758cf5b9b404

This fix is for version 1.4.7 (not in tree, yet) which apparently reworked the src/modules/loaders/loader_gif.c file quite a bit.

For versions in tree you need my patch above.
Comment 7 SpanKY gentoo-dev 2015-05-11 16:32:05 UTC 
should be all set now in the tree; thanks for the report!

Commit message: Version bump
http://sources.gentoo.org/media-libs/imlib2/imlib2-1.4.7.ebuild?rev=1.1