Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 538482 - mail-mta/nullmailer with sys-libs/musl - missing include to unistd.h for uid_t
Summary: mail-mta/nullmailer with sys-libs/musl - missing include to unistd.h for uid_t
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Robin Johnson
URL:
Whiteboard:
Keywords:
: 542484 (view as bug list)
Depends on:
Blocks: musl-porting
  Show dependency tree
 
Reported: 2015-02-01 22:52 UTC by Fredric Johansson
Modified: 2015-03-08 01:51 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Fix for building on musl (mail-mta-nullmailer-uid_t.patch,30.75 KB, patch)
2015-02-01 22:52 UTC, Fredric Johansson
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fredric Johansson 2015-02-01 22:52:00 UTC
Created attachment 395352 [details, diff]
Fix for building on musl

nullmailer fails to build against musl. missing include to unistd.h for uid_t
Attaching patch for hardened-dev:musl
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2015-02-02 10:41:25 UTC
Comment on attachment 395352 [details, diff]
Fix for building on musl

I don't know how you generate these, but entire ChangeLogs should definitely not be included in your patches.
Comment 2 Justin Lecher (RETIRED) gentoo-dev 2015-02-02 10:49:19 UTC
Need a clean patch, otherwise I cannot support this.
Comment 3 Anthony Basile gentoo-dev 2015-02-02 11:39:07 UTC
(In reply to Justin Lecher from comment #2)
> Need a clean patch, otherwise I cannot support this.

I think he's asking me to apply that to the hadened-dev::musl overlay.  Although the changelog is not necessary for sure, I do appreciate the clean application to the overlay rather than piecing stuff in.

Anyhow, I already have a pull request upstream/github for nullmailer.

   https://github.com/bruceg/nullmailer/pull/25

The problem is pretty much a non-brainer.  Header stacking in glibc pulls in typedefs of uid_t and gid_t without directly including <unistd.h>.  This breaks posix and is not portable.
Comment 4 Justin Lecher (RETIRED) gentoo-dev 2015-02-02 11:46:48 UTC
(In reply to Anthony Basile from comment #3)
> The problem is pretty much a non-brainer.  Header stacking in glibc pulls in
> typedefs of uid_t and gid_t without directly including <unistd.h>.  This
> breaks posix and is not portable.


I assume this completely compatible with glibc and other libc implementations?
Comment 5 Justin Lecher (RETIRED) gentoo-dev 2015-02-02 11:50:11 UTC
+  02 Feb 2015; Justin Lecher <jlec@gentoo.org> nullmailer-1.13-r5.ebuild,
+  +files/nullmailer-1.13-unistd.h.patch:
+  Import header in portable way, #538482
+
Comment 6 Anthony Basile gentoo-dev 2015-03-08 01:51:29 UTC
*** Bug 542484 has been marked as a duplicate of this bug. ***