Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 538300 - sys-devel/bison: examples/test require dev-lang/perl
Summary: sys-devel/bison: examples/test require dev-lang/perl
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
: 571492 (view as bug list)
Depends on: 548778
Blocks: prefix-gx86
  Show dependency tree
 
Reported: 2015-01-30 23:03 UTC by Ben Kohler
Modified: 2016-01-11 04:08 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,5.49 KB, text/plain)
2015-01-30 23:03 UTC, Ben Kohler
Details
self-contained patch for optional examples needing perl (bison-3.0.4-optional-perl-gen.patch,37.38 KB, patch)
2015-04-10 16:40 UTC, Michael Haubenwallner (RETIRED)
Details | Diff
better patch the generated files only (bison-3.0.4-optional-perl-gen.patch,37.39 KB, patch)
2015-04-27 07:59 UTC, Michael Haubenwallner (RETIRED)
Details | Diff
better patch the generated files only (bison-3.0.4-optional-perl-gen.patch,38.08 KB, patch)
2015-04-27 10:43 UTC, Michael Haubenwallner (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Kohler gentoo-dev 2015-01-30 23:03:55 UTC
Created attachment 395234 [details]
build.log

bison cannot build without perl, it should have dev-lang/perl in DEPEND
Comment 1 SpanKY gentoo-dev 2015-04-03 06:35:53 UTC
the normal program does not need perl at build or runtime.  making it a hard dependency would be really bad.
Comment 2 SpanKY gentoo-dev 2015-04-03 07:03:45 UTC
should be all set now in the tree; thanks for the report!

Commit message: Make examples optional and fix perl dependency
http://sources.gentoo.org/sys-devel/bison/bison-3.0.4-r1.ebuild?rev=1.1
http://sources.gentoo.org/sys-devel/bison/files/bison-3.0.4-optional-perl.patch?rev=1.1
Comment 3 Mikael Magnusson 2015-04-06 00:01:57 UTC
The eautoreconf call doesn't work for me. It complains,

***** automake --add-missing --copy --force-missing
configure.ac:44: error: require Automake 1.14, but have 1.13.4

I have automake 1.14 installed, adding WANT_AUTOMAKE=1.4 causes another set of errors to be logged,

***** aclocal -I m4
aclocal: configure.ac: 49: macro `AM_SILENT_RULES' not found in library
aclocal: macro `_gl_DEFUN_ONCE([$1' required but not defined
aclocal: macro `gl_MULTIARCH' required but not defined
aclocal: macro `AM_PROG_MKDIR_P' required but not defined
aclocal: macro `gl_USE_SYSTEM_EXTENSIONS' required but not defined
aclocal: macro `gl_CHECK_SOCKET_HEADERS' required but not defined
aclocal: macro `gl_SYS_IOCTL_H_DEFAULTS' required but not defined
aclocal: macro `gl_USE_SYSTEM_EXTENSIONS' required but not defined
aclocal: macro `gl_USE_SYSTEM_EXTENSIONS' required but not defined
aclocal: macro `gl_SNPRINTF_RETVAL_C99' required but not defined
aclocal: macro `gl_PREREQ_VASNPRINTF_LONG_DOUBLE' required but not defined
aclocal: macro `gl_PREREQ_VASNPRINTF' required but not defined
aclocal: macro `gl_USE_SYSTEM_EXTENSIONS' required but not defined
aclocal: macro `gl_ICONV_H_DEFAULTS' required but not defined
aclocal: macro `AM_PROG_MKDIR_P' required but not defined
aclocal: macro `gl_INTTYPES_INCOMPLETE' required but not defined
aclocal: macro `gl_STDINT_H' required but not defined
aclocal: macro `gl_MULTIARCH' required but not defined
aclocal: macro `gl_USE_SYSTEM_EXTENSIONS' required but not defined
aclocal: macro `gl_USE_SYSTEM_EXTENSIONS' required but not defined
aclocal: macro `gl_HEADER_ERRNO_H' required but not defined
aclocal: macro `gl_USE_SYSTEM_EXTENSIONS' required but not defined
aclocal: macro `gl_HEADER_ERRNO_H' required but not defined
aclocal: macro `gl_HEADER_ERRNO_H' required but not defined
aclocal: macro `gl_LIBUNISTRING' required but not defined
aclocal: macro `gl_ENVIRON' required but not defined
aclocal: macro `gl_ENVIRON' required but not defined
aclocal: macro `AM_PROG_CC_C_O' required but not defined
aclocal: macro `gl_USE_SYSTEM_EXTENSIONS' required but not defined
aclocal: macro `gl_HEADER_ERRNO_H' required but not defined
Comment 4 Mikael Magnusson 2015-04-06 00:03:42 UTC
I don't know how I made the same typo three times without noticing... Setting WANT_AUTOMAKE=1.14 makes it work as expected :).
Comment 5 Michael Haubenwallner (RETIRED) gentoo-dev 2015-04-10 11:02:08 UTC
(In reply to SpanKY from comment #2)

As we have bison in stage2 of Prefix bootstrap, could you use a self-contained patch instead of eautoreconf please?
Comment 6 Michael Haubenwallner (RETIRED) gentoo-dev 2015-04-10 16:40:00 UTC
Created attachment 400974 [details, diff]
self-contained patch for optional examples needing perl

bison-3.0.4 ships with automake-1.15 already, patch is based on that one.
Comment 7 Michael Haubenwallner (RETIRED) gentoo-dev 2015-04-27 07:59:21 UTC
Created attachment 402096 [details, diff]
better patch the generated files only

Besides autotools-output, patching autotools-input as well may trigger running autotools during make - better avoid that by patching the -output only.
Comment 8 SpanKY gentoo-dev 2015-04-27 09:01:40 UTC
(In reply to Mikael Magnusson from comment #3)

that is bug 545610

(In reply to Michael Haubenwallner from comment #5)

what is the exact list of packages that prefix needs to boostrap with ?  this list needs to be explicitly documented & noted in the tree, as well as agreed upon by the maintainers of said packages.

(In reply to Michael Haubenwallner from comment #7)

you stripped out all the metadata in the header that must be in all patches
Comment 9 Michael Haubenwallner (RETIRED) gentoo-dev 2015-04-27 10:43:53 UTC
Created attachment 402104 [details, diff]
better patch the generated files only

(In reply to SpanKY from comment #8)
> (In reply to Michael Haubenwallner from comment #5)
> 
> what is the exact list of packages that prefix needs to boostrap with ? 
> this list needs to be explicitly documented & noted in the tree, as well as
> agreed upon by the maintainers of said packages.

-> Bug#547888

> (In reply to Michael Haubenwallner from comment #7)
> 
> you stripped out all the metadata in the header that must be in all patches

Indeed... fixed.
Comment 10 Michael Haubenwallner (RETIRED) gentoo-dev 2015-05-07 12:03:30 UTC
And to avoid the need for help2man after patching:

 src_prepare() {
     epatch "${FILESDIR}"/${P}-optional-perl-gen.patch #538300
+    touch doc/bison.1 #548778
 }
Comment 11 SpanKY gentoo-dev 2015-05-08 08:33:42 UTC
should be all set now in the tree; thanks for the report!

Commit message: Patch generated autotools to avoid breaking prefix bootstrap
http://sources.gentoo.org/sys-devel/bison/bison-3.0.4-r1.ebuild?r1=1.2&r2=1.3
http://sources.gentoo.org/sys-devel/bison/files/bison-3.0.4-optional-perl.patch?r1=1.1&r2=1.2
Comment 12 Michael Haubenwallner (RETIRED) gentoo-dev 2015-05-11 08:15:53 UTC
Thanks a lot!

(In reply to SpanKY from comment #11)
> http://sources.gentoo.org/sys-devel/bison/files/bison-3.0.4-optional-perl.
> patch?r1=1.1&r2=1.2

One side note: Not commenting out the unused @@ (hunk starter) lines as well requires GNU patch 2.6 or later, while prefix bootstrap did check for no particular version of GNU patch until now.
Let's see if 2.7.x works on OSX 10.6.x now: http://sourceforge.net/p/gentooprefixtree/code/ci/0fb0b39d929f826b5f0390fed8887b965ced787d
Comment 13 SpanKY gentoo-dev 2016-01-11 03:59:54 UTC
*** Bug 571492 has been marked as a duplicate of this bug. ***
Comment 14 SpanKY gentoo-dev 2016-01-11 04:08:56 UTC
i've backported some of the simple stuff to the 2.7.1 ebuild:
http://gitweb.gentoo.org/repo/gentoo.git/commit/?id=098bb0ab0f88679edefd7516d9697c46e289d558

but if it still fails, well we'll just wait for 3.0.4-r1 to go stable