Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 535966 - gnome2.eclass: drop gnome2_src_unpack
Summary: gnome2.eclass: drop gnome2_src_unpack
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: gnome2.eclass 530046
  Show dependency tree
 
Reported: 2015-01-07 19:18 UTC by Pacho Ramos
Modified: 2015-01-29 09:35 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pacho Ramos gentoo-dev 2015-01-07 19:18:54 UTC
I was reviewing the needed changes to kill support for eapi0 and eapi1 (bug #530046) but I noticed that our gnome2_src_unpack function is not the same as default one:
# @FUNCTION: gnome2_src_unpack
# @DESCRIPTION:
# Stub function for old EAPI.
gnome2_src_unpack() {
        unpack ${A}
        cd "${S}"
        has ${EAPI:-0} 0 1 && gnome2_src_prepare
}

Reading:
http://devmanual.gentoo.org/ebuild-writing/functions/src_unpack/

We would still need it for current EAPIs for the "cd ${S}" :/

No reverse dep is manually calling gnome2_src_unpack and, then, it shouldn't be hard to kill... but where should we move the "cd ${S}" part? Should it be moved to gnome2_src_prepare? Would be safe to do that?
Comment 1 Pacho Ramos gentoo-dev 2015-01-29 09:35:02 UTC
Ah, as I read in PMS for src_prepare:
"The initial working directory is S, with an error or fallback to WORKDIR as discussed in section 9.1.1."