Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 533600 - mail-client/trojita-9999 - add USE=qt5
Summary: mail-client/trojita-9999 - add USE=qt5
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Jan Kundrát (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-26 12:38 UTC by Andreas Sturmlechner
Modified: 2015-01-29 15:22 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
trojita-9999.ebuild.diff (trojita-9999.ebuild.diff,1.60 KB, patch)
2014-12-26 12:38 UTC, Andreas Sturmlechner
Details | Diff
trojita-9999-fix-build-with-qt5keychain.patch (trojita-9999-fix-build-with-qt5keychain.patch,426 bytes, patch)
2014-12-26 12:39 UTC, Andreas Sturmlechner
Details | Diff
trojita-9999.ebuild.diff (trojita-9999.ebuild.diff,1.77 KB, patch)
2015-01-12 10:32 UTC, Andreas Sturmlechner
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Sturmlechner gentoo-dev 2014-12-26 12:38:42 UTC
Created attachment 392434 [details, diff]
trojita-9999.ebuild.diff

They have been doing qt5 work for some time.
Comment 1 Andreas Sturmlechner gentoo-dev 2014-12-26 12:39:53 UTC
Created attachment 392436 [details, diff]
trojita-9999-fix-build-with-qt5keychain.patch

patch to make trojita[password] build with dev-libs/qtkeychain[qt5,-qt4]
Comment 2 Jan Kundrát (RETIRED) gentoo-dev 2015-01-12 09:10:37 UTC
Hi, sorry for a big delay in responding to this one. The Qt5 build fixes look good with a couple of problems:

- The dev-qt/qtsql:5 should be dev-qt/qtsql:5[sqlite] because that particular plugin is required.
- I had to check that the qtbearer dependency is now indeed moved to dev-qt/qtnerwork even though upstream doesn't release such a module.

I do not have Qt5 installed via Gentoo's Portage, I rely on my own builds, so I cannot really test its validity.

-> Dear Qt team, I do not have gentoo-x86 commit access, please push these changes on my behalf. I would appreciate not merging the trojita-9999-fix-build-with-qt5keychain.patch as-is because that's an upstream bug which I expect to fix shortly.

I've uploaded the qt5keychain patch to https://gerrit.vesnicky.cesnet.cz/r/315 .
Comment 3 Andreas Sturmlechner gentoo-dev 2015-01-12 10:05:15 UTC
(In reply to Jan Kundrát from comment #2)
> - The dev-qt/qtsql:5 should be dev-qt/qtsql:5[sqlite] because that
> particular plugin is required.

ah sorry, I forgot to update the patch here after finding the same.

> I've uploaded the qt5keychain patch to
> https://gerrit.vesnicky.cesnet.cz/r/315 .

thanks! :)
Comment 4 Jan Kundrát (RETIRED) gentoo-dev 2015-01-12 10:24:31 UTC
> -> Dear Qt team, I do not have gentoo-x86 commit access, please push these
> changes on my behalf. I would appreciate not merging the
> trojita-9999-fix-build-with-qt5keychain.patch as-is because that's an
> upstream bug which I expect to fix shortly.

The patch is now merged into upstream git, and as such the -9999 version no longer needs it.

Andreas, I suppose an updated patch which fixes the two minor problems (missing sqlite dep, and your patch) would help the Qt team to commit this sooner.
Comment 5 Andreas Sturmlechner gentoo-dev 2015-01-12 10:32:57 UTC
Created attachment 393768 [details, diff]
trojita-9999.ebuild.diff

done, also built successfully.
Comment 6 Davide Pesavento gentoo-dev 2015-01-12 10:46:53 UTC
(In reply to Jan Kundrát from comment #2)
> - I had to check that the qtbearer dependency is now indeed moved to
> dev-qt/qtnerwork even though upstream doesn't release such a module.

The bearer plugins are part of dev-qt/qtnetwork:5, yes. In qt4 the QtNetwork module is part of dev-qt/qtcore:4, so the plugins had to be split into dev-qt/qtbearer:4 to avoid a circular dep involving qtdbus.
Comment 7 Jan Kundrát (RETIRED) gentoo-dev 2015-01-28 22:41:09 UTC
Hi Qt or KDE teams, could you please commit the associated patch? I don't have commit access to gentoo-x86.
Comment 8 Michael Palimaka (kensington) gentoo-dev 2015-01-29 15:22:21 UTC
Thanks, fixed in CVS.

+  29 Jan 2015; Michael Palimaka <kensington@gentoo.org> trojita-9999.ebuild:
+  Add Qt 5 support by Andreas Sturmlechner <andreas.sturmlechner@gmail.com> wrt
+  bug #533600.