Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 533460 - repoman gives wrong warnings about invalid copyright header
Summary: repoman gives wrong warnings about invalid copyright header
Status: CONFIRMED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Repoman (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-24 15:21 UTC by Julian Ospald
Modified: 2021-01-11 20:33 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Ospald 2014-12-24 15:21:06 UTC
Any copyright header that does not say

# Copyright <years> Gentoo Foundation
# Distributed under the terms of the GNU General Public License v2
# $Header: [random string] $

is wrong to repoman. Does that mean anyone running an overlay is expected to give copyright to gentoo foundation?
Comment 1 Zac Medico gentoo-dev 2014-12-24 16:31:20 UTC
We really need to provide a way for the repository to disable specific repoman checks, using either metadata/layout.conf or a new config file included in the repository.
Comment 2 Julian Ospald 2014-12-24 16:36:24 UTC
I'd say a new config file makes more sense, because disabling repoman warnings doesn't change the repository layout.
Comment 3 Manuel Rüger (RETIRED) gentoo-dev 2014-12-24 17:57:08 UTC
In addition disabling repoman checks in package's metadata.xml, would be nice, too. 
So we could easily mask false positives, without adding too much complexity to the repoman checks.
Comment 4 Julian Ospald 2014-12-24 18:14:50 UTC
(In reply to Manuel Rüger from comment #3)
> In addition disabling repoman checks in package's metadata.xml, would be
> nice, too. 
> So we could easily mask false positives, without adding too much complexity
> to the repoman checks.

Same here... disabling repoman checks doesn't change the metadata of an ebuild and shouldn't be there.

We can make a config file that accepts package specific syntax.
Comment 5 Zac Medico gentoo-dev 2014-12-24 18:22:48 UTC
(In reply to Manuel Rüger from comment #3)
> In addition disabling repoman checks in package's metadata.xml, would be
> nice, too. 

FWIW, you can disable some warnings by adding #nowarn to the end of the line that triggers the warning:

https://github.com/gentoo/portage/commit/de51993645f9656dfa8a74f6bf9cc85ed56ee8fa