Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 529348 - net-misc/dhcpcd-6.4.7: fix compilation on musl branch
Summary: net-misc/dhcpcd-6.4.7: fix compilation on musl branch
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Anthony Basile
URL:
Whiteboard: hardened-devel repo, musl overlay
Keywords: PATCH
Depends on:
Blocks: musl-porting
  Show dependency tree
 
Reported: 2014-11-15 16:10 UTC by DaggyStyle
Modified: 2015-03-06 22:25 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch (dhcpcd-6.4.7-musl-fix.patch,3.21 KB, patch)
2014-11-15 16:12 UTC, DaggyStyle
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description DaggyStyle 2014-11-15 16:10:34 UTC
this patch allow net-misc/dhcpcd-6.4.7 to compile and run under gentoo over musl


Reproducible: Always
Comment 1 DaggyStyle 2014-11-15 16:12:22 UTC
Created attachment 389412 [details, diff]
patch
Comment 2 Felix Janda 2014-11-16 08:35:17 UTC
Just to have it documented somewhere: Starting from version 6.6.2 no patch is needed anymore.
Comment 3 DaggyStyle 2014-11-16 17:50:35 UTC
(In reply to Felix Janda from comment #2)
> Just to have it documented somewhere: Starting from version 6.6.2 no patch
> is needed anymore.

good to know, but as I'm working on stable tree and 6.4.7 is the last stable version, it is still relevant
Comment 4 Anthony Basile gentoo-dev 2015-01-03 16:44:28 UTC
(In reply to DaggyStyle from comment #3)
> (In reply to Felix Janda from comment #2)
> > Just to have it documented somewhere: Starting from version 6.6.2 no patch
> > is needed anymore.
> 
> good to know, but as I'm working on stable tree and 6.4.7 is the last stable
> version, it is still relevant

If you want, you can port the 6.6.2 ebuild to the overlay and mark it stable without any extra patch.  As with the other bugs, make a single commit against hardened-dev::musl overlay and upload the patch
Comment 5 Anthony Basile gentoo-dev 2015-01-31 21:06:47 UTC
Instructions on producing a patch against the hardened-dev::musl overlay

1. git clone git://git.overlays.gentoo.org/proj/hardened-dev.git

2. git checkout musl

3. (add the ebuild and patch etc.  make sure the ebuild has rev version -r99.  look at other ebuilds in that overlay for examples)

4. git add .

5. git commit -m "<cat>/<pkg>: fixed to buidl on musl"

6. git format-patch HEAD^

7. attack to the bug.
Comment 6 Felix Janda 2015-03-06 21:50:59 UTC
Version 6.6.7 is now stable for all relevant archs and seems to
compile fine without any patches.
Comment 7 SpanKY gentoo-dev 2015-03-06 22:25:54 UTC
(In reply to Felix Janda from comment #6)

thanks for following up