Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 527778 - net-firewall/shorewall-core should only use RDEPEND for SELinux policy package dependency
Summary: net-firewall/shorewall-core should only use RDEPEND for SELinux policy packag...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Thomas Deutschmann (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 527698
  Show dependency tree
 
Reported: 2014-11-01 11:05 UTC by Sven Vermeulen (RETIRED)
Modified: 2014-11-02 20:15 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sven Vermeulen (RETIRED) gentoo-dev 2014-11-01 11:05:39 UTC 
Please remove the "selinux? ( sec-policy/selinux-* )" dependency in the DEPEND variable (not RDEPEND). Take this into account with your next package bump - if after 6 months there have been no need for other package upgrades, we will be bumping the package(s) ourselves with just this change.

For more information, see our tracker Bug #527698 [1]. The requested change will be posted as a separate comment/patch. Note that if the package also depends on libselinux, libselinux itself should still remain in DEPEND and RDEPEND.

[1] https://bugs.gentoo.org/show_bug.cgi?id=527698


Reproducible: Always
Comment 1 Sven Vermeulen (RETIRED) gentoo-dev 2014-11-01 11:05:50 UTC 
Index: shorewall-core-4.5.21.10.ebuild
===================================================================
RCS file: /var/cvsroot/gentoo-x86/net-firewall/shorewall-core/shorewall-core-4.5.21.10.ebuild,v
retrieving revision 1.1
diff -u -B -r1.1 shorewall-core-4.5.21.10.ebuild
--- shorewall-core-4.5.21.10.ebuild     12 Jun 2014 13:59:29 -0000      1.1
+++ shorewall-core-4.5.21.10.ebuild     1 Nov 2014 11:05:07 -0000
@@ -34,7 +34,6 @@
        >=dev-lang/perl-5.10
        virtual/perl-Digest-SHA
        !<net-firewall/shorewall-4.5.0.1
-       selinux? ( >=sec-policy/selinux-shorewall-2.20130424-r2 )
 "
 RDEPEND="
        ${DEPEND}
@@ -42,6 +41,7 @@
        >=sys-apps/iproute2-3.8.0[-minimal]
        >=sys-devel/bc-1.06.95
        >=sys-apps/coreutils-8.20
+       selinux? ( >=sec-policy/selinux-shorewall-2.20130424-r2 )
 "
 
 DOCS=( changelog.txt releasenotes.txt )
Index: shorewall-core-4.5.21.9.ebuild
===================================================================
RCS file: /var/cvsroot/gentoo-x86/net-firewall/shorewall-core/shorewall-core-4.5.21.9.ebuild,v
retrieving revision 1.8
diff -u -B -r1.8 shorewall-core-4.5.21.9.ebuild
--- shorewall-core-4.5.21.9.ebuild      19 Sep 2014 09:17:43 -0000      1.8
+++ shorewall-core-4.5.21.9.ebuild      1 Nov 2014 11:05:07 -0000
@@ -34,7 +34,6 @@
        >=dev-lang/perl-5.10
        virtual/perl-Digest-SHA
        !<net-firewall/shorewall-4.5.0.1
-       selinux? ( >=sec-policy/selinux-shorewall-2.20130424-r2 )
 "
 RDEPEND="
        ${DEPEND}
@@ -42,6 +41,7 @@
        >=sys-apps/iproute2-3.8.0[-minimal]
        >=sys-devel/bc-1.06.95
        >=sys-apps/coreutils-8.20
+       selinux? ( >=sec-policy/selinux-shorewall-2.20130424-r2 )
 "
 
 DOCS=( changelog.txt releasenotes.txt )
Comment 2 Sven Vermeulen (RETIRED) gentoo-dev 2014-11-02 08:51:19 UTC 
After checking with a few colleague developers it seems that this change does not need a revision bump after all. As such, I will make the necessary changes to the packages myself.

My apologies for the noise.
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2014-11-02 20:15:28 UTC 
No, that's fixed, not obsolete.