527662 – xfce-base/xfwm4 - window borders do not respond to touch screen

Bug 527662 - xfce-base/xfwm4 - window borders do not respond to touch screen

Summary: xfce-base/xfwm4 - window borders do not respond to touch screen

Status:	RESOLVED OBSOLETE

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	XFCE Team

URL:
Whiteboard:
Keywords:	PATCH

Depends on:
Blocks:

Reported:	2014-10-31 20:59 UTC by James C. Georgas
Modified:	2017-03-21 16:28 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
patch (subwindow-fix.patch,661 bytes, patch) 2014-10-31 21:00 UTC, James C. Georgas	Details \| Diff
modified ebuild (xfwm4-4.10.1-r1.ebuild,1.43 KB, text/plain) 2014-10-31 21:01 UTC, James C. Georgas	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description James C. Georgas 2014-10-31 20:59:40 UTC

This is a patch to fix Xfwm4 window borders not responding to touch screen events.

The event structure that xfwm4 gets for touch screen events is missing the subwindow information. The patch queries the current pointer position and fills it in.

Reproducible: Always

Comment 1 James C. Georgas 2014-10-31 21:00:33 UTC

Created attachment 387912 [details, diff]
patch

Comment 2 James C. Georgas 2014-10-31 21:01:05 UTC

Created attachment 387914 [details]
modified ebuild

Comment 3 James C. Georgas 2014-10-31 21:03:20 UTC

Credit to Andreas Lampersperger for the original patch at:

http://xfce.10915.n7.nabble.com/Re-Xfwm-window-borders-do-not-respond-to-touch-screen-td42357.html

Comment 4 Jason Zaman gentoo-dev

2015-07-04 15:03:19 UTC

applied in xfwm4-4.12.3-r1, can you test it? I dont have a touchscreen.

This should ideally also be reported upstream.

+  04 Jul 2015; Jason Zaman <perfinion@gentoo.org>
+  +files/xfwm4-4.12-touchscreen-subwindow-fix.patch, +xfwm4-4.12.3-r1.ebuild:
+  fix bug 527662, respond to touchscreen

Comment 5 Michał Górny archtester

2017-03-16 09:22:01 UTC

Where's the upstream bug for this?

Comment 6 James C. Georgas 2017-03-17 02:53:57 UTC

(In reply to Michał Górny from comment #5)
> Where's the upstream bug for this?

I couldn't find a report in their bug tracker; I just took the fix from the linked mailing list. I'll retest in a couple of days without the ebuild patch, to see if its still a bug upstream.

Comment 7 James C. Georgas 2017-03-17 02:55:39 UTC

(In reply to James C. Georgas from comment #6)
> (In reply to Michał Górny from comment #5)
> > Where's the upstream bug for this?
> 
> I couldn't find a report in their bug tracker; I just took the fix from the
> linked mailing list. I'll retest in a couple of days without the ebuild
> patch, to see if its still a bug upstream.

but the patch works on my system; I should have updated the status to address the test request. Sorry about that.

Comment 8 James C. Georgas 2017-03-21 15:45:40 UTC

Ok, I just tested without the patch, and it seems to work now, so I guess the issue was fixed upstream (in X?) at some point. What should happen to the xfwm4-4.12.3-r1 ebuild now?

Comment 9 Michał Górny archtester

2017-03-21 16:28:08 UTC

(In reply to James C. Georgas from comment #8)
> Ok, I just tested without the patch, and it seems to work now, so I guess
> the issue was fixed upstream (in X?) at some point. What should happen to
> the xfwm4-4.12.3-r1 ebuild now?

Nothing special. It will just just be removed at some point.