Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 526468 - dev-vcs/stgit: USE="doc" builds documentation twice
Summary: dev-vcs/stgit: USE="doc" builds documentation twice
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: René 'Necoro' Neumann
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-22 11:48 UTC by René 'Necoro' Neumann
Modified: 2014-10-23 09:13 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch proposal for stgit-0.17.1-r1 (stgit-single-build.patch,1.34 KB, patch)
2014-10-22 20:50 UTC, René 'Necoro' Neumann
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description René 'Necoro' Neumann 2014-10-22 11:48:53 UTC
The current ebuilds are building the docs twice. This is not really a 'bug' but more of a nuisance, as this building takes some time.

This bug is therefore a reminder for me to look into this and try to fix it (if it it's possible -- I think the new python-eclass is to blame...).
Comment 1 Yixun Lan archtester gentoo-dev 2014-10-22 14:40:16 UTC
I think we should not blame the python eclass, actually it build once in src_compile(), another time in src_install(), better fix the build script.
Comment 2 René 'Necoro' Neumann 2014-10-22 20:50:52 UTC
Created attachment 387244 [details, diff]
Patch proposal for stgit-0.17.1-r1

What do you think about this patch? The general idea: StGit's doc building process depends on stgit/commands/cmdlist.py, which is generated unconditionally(!) in setup.py. Thus we need to fix some order, so that it is generated before 'make doc', and not regenerated inbetween 'make doc' and 'make install-doc'. This is achieved by using src_{compile,install} instead of python_{compile,install}_all, as the latter fixes the order diametrically to our needs :(

The other option would be to fix the build system, but I'd rather not touch it -- seems fragile...
Comment 3 Yixun Lan archtester gentoo-dev 2014-10-23 01:57:34 UTC
sounds good, fix pushed in tree, but only for 0.17.1-r1 (thought we may stabilize this version, then eventually drop 0.16).

I've removed the big chunk of comments, and just left the bug id for tracking.

also dropped the "python_setup" which I think it was already handled by previous phases?
Comment 4 René 'Necoro' Neumann 2014-10-23 09:13:29 UTC
(In reply to Yixun Lan from comment #3)
> sounds good, fix pushed in tree, but only for 0.17.1-r1 (thought we may
> stabilize this version, then eventually drop 0.16).

Yes, this is what I intended.

> I've removed the big chunk of comments, and just left the bug id for
> tracking.

Ok. The reason I tend to insert large comments into ebuilds is to remember why something is done the way it is, when looking into it 2 years later :)

> also dropped the "python_setup" which I think it was already handled by
> previous phases?

I wasn't 100% sure, that's why I inserted it there (better safe than sorry...).