526300 – net-firewall/ufw-0.34_pre805-r1: bashcomp uses deprecated 'have' command

Bug 526300 - net-firewall/ufw-0.34_pre805-r1: bashcomp uses deprecated 'have' command

Summary: net-firewall/ufw-0.34_pre805-r1: bashcomp uses deprecated 'have' command

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Sławomir Nizio

URL:
Whiteboard:
Keywords:	PATCH

Depends on:
Blocks:	bashcomp2
	Show dependency tree

Reported:	2014-10-21 17:31 UTC by Michał Górny
Modified:	2014-12-15 11:07 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
patch to create -r2 (ufw-r2.patch,344 bytes, patch) 2014-12-13 12:51 UTC, Sławomir Nizio	Details \| Diff
patch that goes under "files" (ufw-0.34_pre805-bash-completion.patch,255 bytes, patch) 2014-12-13 12:52 UTC, Sławomir Nizio	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michał Górny archtester

2014-10-21 17:31:24 UTC

* Problems with installed bash completions were found:
 * 
 * 	ufw: 'have' command is deprecated and must not be used.
 * 
 * For more details on installing bash-completions, please see:
 * https://wiki.gentoo.org/wiki/Bash/Installing_completion_files

Please remove the 'have' call and enable the completion unconditionally.

Comment 1 Sławomir Nizio 2014-12-13 12:51:56 UTC

Created attachment 391566 [details, diff]
patch to create -r2

Comment 2 Sławomir Nizio 2014-12-13 12:52:34 UTC

Created attachment 391568 [details, diff]
patch that goes under "files"

Comment 3 Sławomir Nizio 2014-12-13 12:57:07 UTC

That's it, but this is also an opportunity to remove the older ebuild, using the older Python/distutils eclass. :)

rm net-firewall/ufw/files/ufw-0.31.1-python-abis.patch
rm net-firewall/ufw/ufw-0.34_pre805.ebuild

^ This will do.

If you wish, you could also remove the ebuild that is currently newest, replaced by -r2 from the first patch: ufw-0.34_pre805-r1.ebuild.

Comment 4 Sergey Popov gentoo-dev

2014-12-15 11:07:47 UTC

+*ufw-0.34_pre805-r2 (15 Dec 2014)
+
+  15 Dec 2014; Sergey Popov <pinkbyte@gentoo.org> -ufw-0.34_pre805.ebuild,
+  +ufw-0.34_pre805-r2.ebuild, +files/ufw-0.34_pre805-bash-completion.patch:
+  Revision bump: fix bash completion, wrt bug #526300, drop old revision

Thanks for the fix!