Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 526040 - sys-apps/net-tools: updated SCTP/IPX patches
Summary: sys-apps/net-tools: updated SCTP/IPX patches
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 483058
  Show dependency tree
 
Reported: 2014-10-20 11:29 UTC by Joshua Kinard
Modified: 2015-08-29 06:47 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
IPX patch for net-tools-1.60_p20141019041918 (1001_net-tools-1.60-ipx.patch,1.36 KB, patch)
2014-10-20 11:29 UTC, Joshua Kinard
Details | Diff
SCTP statistics patch for net-tools-1.60_p20141019041918 (1002_net-tools-1.60-sctp-statistics.patch,16.73 KB, patch)
2014-10-20 11:29 UTC, Joshua Kinard
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Kinard gentoo-dev 2014-10-20 11:29:09 UTC
Created attachment 387040 [details, diff]
IPX patch for net-tools-1.60_p20141019041918

I have re-synced the IPX patch and SCTP stats patch to apply cleanly against sys-apps/net-tools-1.60_p20141019041918.  Tested both on amd64 and mips.

For the IPX patch:
Before:
Active IPX sockets
Proto Recv-Q Send-Q Local Address    Foreign Address            State
IPX        0      0 01000000:400A    -
IPX        0      0 01000000:4009    -
IPX        0      0 01000000:4008    041412AC:000000000001:0451 ESTAB
                    ^^^^^^^^         ^^^^^^^^

After:
Active IPX sockets
Proto Recv-Q Send-Q Local Address    Foreign Address            State
IPX        0      0 00000001:400A    -
IPX        0      0 00000001:4009    -
IPX        0      0 00000001:4008    AC121404:000000000001:0451 ESTAB
                    ^^^^^^^^         ^^^^^^^^

For the SCTP patch:
netstat -anSp:
Active Internet connections (servers and established)
Proto Recv-Q Send-Q Local Address   Foreign Address  State      PID/Program name
sctp       0      0 172.18.20.4:22  0.0.0.0:*        LISTEN     26690/sshd
SCTP error in line: 2
SCTP error in line: 1
      Bug ^^^^^^

After applying "net-tools-sctp-statistics.patch" from Fedora:
Active Internet connections (servers and established)
Proto Recv-Q Send-Q Local Address   Foreign Address  State      PID/Program name
sctp                172.18.20.4:22                   LISTEN     26690/sshd
sctp                fd00::1:86:22                    LISTEN     26690/sshd
sctp       0      0 fd00::1:86:5774 fd00::1:30:22    ESTABLISHED 12123/ssh

(Output columns had extra whitespace removed to fit into Bugzilla)
Comment 1 Joshua Kinard gentoo-dev 2014-10-20 11:29:48 UTC
Created attachment 387042 [details, diff]
SCTP statistics patch for net-tools-1.60_p20141019041918
Comment 2 SpanKY gentoo-dev 2015-08-26 04:00:40 UTC
where are you testing this ?  on a big endian mips box ?  i'm fairly certain you're changing it from working on little endian & failing on big endian to failing on little endian & passing on big endian.

how are you creating IPX connections ?  do you have some test code i can run ?
i haven't used IPX since Win95 ...
Comment 3 Joshua Kinard gentoo-dev 2015-08-26 07:42:45 UTC
(In reply to SpanKY from comment #2)
> where are you testing this ?  on a big endian mips box ?  i'm fairly certain
> you're changing it from working on little endian & failing on big endian to
> failing on little endian & passing on big endian.
> 
> how are you creating IPX connections ?  do you have some test code i can run
> ?
> i haven't used IPX since Win95 ...

Haven't retested in some time the SCTP stuff.  Have to put that on the TODO list.

For IPX, I have NetWare 3.12 and 4.2 in separate VMs that I can connect to w/ the Linux machines after adding IPX and ncpfs support to the kernels.  Then it's just finagling around with mount.ncpfs to get things working.
Comment 4 SpanKY gentoo-dev 2015-08-29 06:11:33 UTC
i split out the netstat SCTP statistics part and pushed it upstream:
http://sourceforge.net/p/net-tools/code/ci/3bbfa090c95fe2be58c24952870b70d0c618ba1c/
Comment 5 SpanKY gentoo-dev 2015-08-29 06:34:37 UTC
and the netstat part of SCTP now:
http://sourceforge.net/p/net-tools/code/ci/7af48590bf304f1314ba0ea1c8c4cc31aa4f8fdc/

had to do a good bit of code clean up though ... those patches were crufty
Comment 6 SpanKY gentoo-dev 2015-08-29 06:47:20 UTC
and the IPX byte swap patch is in upstream now:
http://sourceforge.net/p/net-tools/code/ci/238f086321e1d7e706df40debc1998f15151bffa/