Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 525208 - sys-fs/cryptsetup[gcrypt] should ewarn users about broken whirlpool
Summary: sys-fs/cryptsetup[gcrypt] should ewarn users about broken whirlpool
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-12 23:26 UTC by Francisco Blas Izquierdo Riera
Modified: 2014-11-09 05:48 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Francisco Blas Izquierdo Riera (RETIRED) gentoo-dev 2014-10-12 23:26:38 UTC
The whirlpool hash on <=dev-libs/libgcrypt-1.60 is broken (see https://bugs.gentoo.org/show_bug.cgi?id=501284 ) which will result in users being unable to open their luks volumes once new versions of libgcrypt are merged. Since this is most likely to trigger after installing a new version of cryptsetup the ebuild should warn users to check https://code.google.com/p/cryptsetup/wiki/FrequentlyAskedQuestions#8._Issues_with_Specific_Versions_of_cryptsetup

Reproducible: Always

Steps to Reproduce:
1. USE="gcrypt" emerge sys-fs/cryptsetup 
Actual Results:  
No reference to broken whirlpool hash

Expected Results:  
elog "<=dev-libs/libgcrypt-1.60 had a broken whirlpool implementation."
elog "If you created any keyslots with such versions using the -h whirlpool"
elog "option they'll be unusable after the upgrade. For a workaround check"
elog "https://code.google.com/p/cryptsetup/wiki/FrequentlyAskedQuestions#8._Issues_with_Specific_Versions_of_cryptsetup"
Comment 1 SpanKY gentoo-dev 2014-11-01 00:58:12 UTC
should be all set now in the tree; thanks for the report!

Commit message: Warn USE=gcrypt users about broken whirlpool hashes
http://sources.gentoo.org/sys-fs/cryptsetup/cryptsetup-1.6.6.ebuild?r1=1.5&r2=1.6
Comment 2 Rick Farina (Zero_Chaos) gentoo-dev 2014-11-01 02:09:18 UTC
(In reply to SpanKY from comment #1)
> should be all set now in the tree; thanks for the report!
> 
> Commit message: Warn USE=gcrypt users about broken whirlpool hashes
> http://sources.gentoo.org/sys-fs/cryptsetup/cryptsetup-1.6.6.ebuild?r1=1.
> 5&r2=1.6

Two minor issues.  First, the broken whirlpool was actually fixed in 1.5.4 as well.  Second, you made two typos.  I've fixed in tree.  Sorry I didn't get to this bug sooner but the original gcrypt bug is around here somewhere with all the details of how the whirlpool fix was released in 1.5.4.
Comment 3 Francisco Blas Izquierdo Riera (RETIRED) gentoo-dev 2014-11-01 02:45:34 UTC
Thank you guys for the fix, quite sure users will appreciate a little bit less of gray hair :)
Comment 4 Francisco Blas Izquierdo Riera (RETIRED) gentoo-dev 2014-11-09 04:56:17 UTC
Moving back to confirmed, testing shows that 1.5.4 still contains the old whirlpool code and reading the patch to 1.5.3 confirms this :(

Can you guys fix the message please?
Comment 5 Rick Farina (Zero_Chaos) gentoo-dev 2014-11-09 05:48:08 UTC
(In reply to Francisco Blas Izquierdo Riera from comment #4)
> Moving back to confirmed, testing shows that 1.5.4 still contains the old
> whirlpool code and reading the patch to 1.5.3 confirms this :(
> 
> Can you guys fix the message please?

Thanks for the extra testing, and the upstream bug report...oh, and the reminder on the bug ;-)

Fixed.