Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 524092 - app-portage/cfg-update-1.8.8: Stops working after bash/shellshock-update to bash-4.2_p50
Summary: app-portage/cfg-update-1.8.8: Stops working after bash/shellshock-update to b...
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Third-Party Tools (show other bugs)
Hardware: All Linux
: Normal critical (vote)
Assignee: Richard Freeman
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-30 07:52 UTC by bugzillamailbox
Modified: 2014-09-30 20:57 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description bugzillamailbox 2014-09-30 07:52:26 UTC
After updating bash to 4.2_p50, cfg-update infinitly loops if there are updates pending on the line containing "bash -c readkey", leading to:

* invalid key... try again: bash: readkey: command not found

Reproducible: Always

Steps to Reproduce:
1. Update bash to 4.2_p50
2. Update any package resulting in config changes
3. Run "cfg-update -u"
Actual Results:  
Infinite loop while trying to read the keypress:

* invalid key... try again: bash: readkey: command not found

printed over and over again.

Expected Results:  
cfg-update asks for the merge like this:

Merge manually with file : /etc/._cfg0000_sudoers ? [y|s|1|2|q]

The affected code line is:
https://github.com/rich0/cfg-update/blob/master/cfg-update#L462
Comment 1 Martin Väth 2014-09-30 12:26:53 UTC
It is strange anyway to use bash from within a perl script.
I suggest to use dev-perl/TermReadKey instead.
Comment 2 Christer Ekholm 2014-09-30 18:15:30 UTC
I have made a pull-request for a fix that uses Term::ReadKey

https://github.com/rich0/cfg-update/pull/5
Comment 3 Richard Freeman gentoo-dev 2014-09-30 20:57:04 UTC
New release in portage.  Thanks, esp to Christer Ekholm for the patch.