Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 523538 - net-misc/arm should depend on sys-process/lsof
Summary: net-misc/arm should depend on sys-process/lsof
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Anthony Basile
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-23 16:15 UTC by Toralf Förster
Modified: 2014-10-09 17:35 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2014-09-23 16:15:48 UTC
There's an error message seen for a short while after arm is started if lsof isn't installed (and I think, the same is true for netstat, or ?)
Comment 1 Anthony Basile gentoo-dev 2014-09-23 21:07:14 UTC
(In reply to Toralf Förster from comment #0)
> There's an error message seen for a short while after arm is started if lsof
> isn't installed (and I think, the same is true for netstat, or ?)

can you please either give the steps to reproduce and the log message.
Comment 2 Toralf Förster gentoo-dev 2014-09-23 21:22:03 UTC
I run as a common user :

$> sudo -u tor arm

(not recommended I think, should add the user to tor's group instead)

and saw for a short moment at page 1/5 of the arm window a string like "lsof not found".

FWIW a grep  
$> grep lsof /usr/share/arm/util/*

gives a lot of findings.
Comment 3 Manuel Rüger (RETIRED) gentoo-dev 2014-09-23 21:42:25 UTC
Which arm version are you talking about? stable version or testing snapshot?
Comment 4 Toralf Förster gentoo-dev 2014-09-24 15:01:25 UTC
(In reply to Manuel Rüger from comment #3)
> Which arm version are you talking about? stable version or testing snapshot?

stable (had difficulties with testing, there the conenctions weren't shown).
And yes - I know, that python 2.7 is needed.
Comment 5 Anthony Basile gentoo-dev 2014-10-04 12:59:38 UTC
(In reply to Manuel Rüger from comment #3)
> Which arm version are you talking about? stable version or testing snapshot?

(In reply to Toralf Förster from comment #4)
> (In reply to Manuel Rüger from comment #3)
> > Which arm version are you talking about? stable version or testing snapshot?
> 
> stable (had difficulties with testing, there the conenctions weren't shown).
> And yes - I know, that python 2.7 is needed.

mrueg, ping.  Anything to add to this?
Comment 6 Manuel Rüger (RETIRED) gentoo-dev 2014-10-04 15:20:13 UTC
(In reply to Anthony Basile from comment #5)
> (In reply to Manuel Rüger from comment #3)
> > Which arm version are you talking about? stable version or testing snapshot?
> 
> (In reply to Toralf Förster from comment #4)
> > (In reply to Manuel Rüger from comment #3)
> > > Which arm version are you talking about? stable version or testing snapshot?
> > 
> > stable (had difficulties with testing, there the conenctions weren't shown).
> > And yes - I know, that python 2.7 is needed.
> 
> mrueg, ping.  Anything to add to this?

Well I can add a new snapshot for stem and arm
Comment 7 Anthony Basile gentoo-dev 2014-10-04 16:41:08 UTC
(In reply to Manuel Rüger from comment #6)
> (In reply to Anthony Basile from comment #5)
> > (In reply to Manuel Rüger from comment #3)
> > > Which arm version are you talking about? stable version or testing snapshot?
> > 
> > (In reply to Toralf Förster from comment #4)
> > > (In reply to Manuel Rüger from comment #3)
> > > > Which arm version are you talking about? stable version or testing snapshot?
> > > 
> > > stable (had difficulties with testing, there the conenctions weren't shown).
> > > And yes - I know, that python 2.7 is needed.
> > 
> > mrueg, ping.  Anything to add to this?
> 
> Well I can add a new snapshot for stem and arm

I guess what I'm thinking is if the new stem+arm version don't need lsof, then we might as well get those stabilized and just drop the older version.
Comment 8 Toralf Förster gentoo-dev 2014-10-05 13:55:44 UTC
(In reply to Manuel Rüger from comment #6)
> Well I can add a new snapshot for stem and arm

I mailed with the current developer:

>Hi Toraif. Yes, python 2.7 is still supported but you're trying to use
>the development codebase. Stem is stable, but arm is undergoing a
>massive rewrite. It works for me at present, but there's numerous
>issues that have slipped in during the overhaul. This is a year long
>project so I can't suggest the arm git repository in the interim.
>
>Cheers! -Damian
Comment 9 Anthony Basile gentoo-dev 2014-10-05 14:43:22 UTC
(In reply to Toralf Förster from comment #8)
> (In reply to Manuel Rüger from comment #6)
> > Well I can add a new snapshot for stem and arm
> 
> I mailed with the current developer:
> 
> >Hi Toraif. Yes, python 2.7 is still supported but you're trying to use
> >the development codebase. Stem is stable, but arm is undergoing a
> >massive rewrite. It works for me at present, but there's numerous
> >issues that have slipped in during the overhaul. This is a year long
> >project so I can't suggest the arm git repository in the interim.
> >
> >Cheers! -Damian

Hey thanks Toralf!  Looks like we should add lsof to RDEPEND and rev bump so people get this change.



(In reply to Toralf Förster from comment #0)
> There's an error message seen for a short while after arm is started if lsof
> isn't installed (and I think, the same is true for netstat, or ?)

It should like there are other things needed too like netstat.  Do we have a list before I make the change?
Comment 10 Toralf Förster gentoo-dev 2014-10-05 15:22:11 UTC
Well, from /usr/lib64/python2.7/site-packages/stem/util/system.py I think that beside netstat and lsof the iproute2 package ("ss") could be usefus as RDEPEND.
The file connection.py indicates this too.

For BSD users there are other commands like sockstat and procstat mentioned -but OTOH if we will have a Gentoo-BSD tor user the he will/sgould complain about such tings or ?
Comment 11 Anthony Basile gentoo-dev 2014-10-06 22:37:04 UTC
(In reply to Toralf Förster from comment #10)
> Well, from /usr/lib64/python2.7/site-packages/stem/util/system.py I think
> that beside netstat and lsof the iproute2 package ("ss") could be usefus as
> RDEPEND.
> The file connection.py indicates this too.
> 
> For BSD users there are other commands like sockstat and procstat mentioned
> -but OTOH if we will have a Gentoo-BSD tor user the he will/sgould complain
> about such tings or ?

`grep -r sysTools.call` gives all the calls to Linux system tools.  These are:

    tail tor sudo ldd man lsof host pgrep pidof netstat ps ulimit

I don't know about the BSD tools and would need help from the freebsd folks for those.  Summarizing the packages, this gives:

    sys-apps/coreutils
    net-misc/tor
    app-admin/sudo
    sys-libs/glibc
    sys-apps/man
    sys-process/lsof
    net-dns/bind-tools
    sys-process/procps
    sys-apps/net-tools

I'll add that list (modulo the system packages) tomorrow.  Let me know if you think I missed anything.
Comment 12 Anthony Basile gentoo-dev 2014-10-09 09:34:02 UTC
(In reply to Anthony Basile from comment #11)
> (In reply to Toralf Förster from comment #10)
> > Well, from /usr/lib64/python2.7/site-packages/stem/util/system.py I think
> > that beside netstat and lsof the iproute2 package ("ss") could be usefus as
> > RDEPEND.
> > The file connection.py indicates this too.
> > 
> > For BSD users there are other commands like sockstat and procstat mentioned
> > -but OTOH if we will have a Gentoo-BSD tor user the he will/sgould complain
> > about such tings or ?
> 
> `grep -r sysTools.call` gives all the calls to Linux system tools.  These
> are:
> 
>     tail tor sudo ldd man lsof host pgrep pidof netstat ps ulimit
> 
> I don't know about the BSD tools and would need help from the freebsd folks
> for those.  Summarizing the packages, this gives:
> 
>     sys-apps/coreutils
>     net-misc/tor
>     app-admin/sudo
>     sys-libs/glibc
>     sys-apps/man
>     sys-process/lsof
>     net-dns/bind-tools
>     sys-process/procps
>     sys-apps/net-tools
> 
> I'll add that list (modulo the system packages) tomorrow.  Let me know if
> you think I missed anything.

I added arm-1.4.5.0-r1.ebuild to the tree with:


# diff -Naur arm-1.4.5.0.ebuild arm-1.4.5.0-r1.ebuild
--- arm-1.4.5.0.ebuild	2012-06-09 07:39:16.000000000 -0400
+++ arm-1.4.5.0-r1.ebuild	2014-10-09 05:32:33.000000000 -0400
@@ -1,6 +1,6 @@
-# Copyright 1999-2012 Gentoo Foundation
+# Copyright 1999-2014 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/net-misc/arm/arm-1.4.5.0.ebuild,v 1.3 2012/06/08 12:12:07 phajdan.jr Exp $
+# $Header: /var/cvsroot/gentoo-x86/net-misc/arm/arm-1.4.5.0-r1.ebuild,v 1.1 2014/10/09 09:32:33 blueness Exp $
 
 EAPI="3"
 PYTHON_DEPEND="2:2.5"
@@ -14,11 +14,18 @@
 
 LICENSE="GPL-3"
 SLOT="0"
-KEYWORDS="amd64 x86 ~x86-fbsd"
+KEYWORDS="~amd64 ~x86 ~x86-fbsd"
 IUSE=""
 
-DEPEND=">=net-misc/tor-0.2.1.27"
-RDEPEND="${DEPEND}"
+# Note: While we depend on net-misc/tor, we strictly speaking
+# don't have to because it could run on a different machine.
+RDEPEND="
+	>=net-misc/tor-0.2.1.27
+	app-admin/sudo
+	sys-apps/man
+	sys-process/lsof
+	net-dns/bind-tools"
+DEPEND="${RDEPEND}"
 
 S="${WORKDIR}/${PN}"


Please test and reopen if this missed any dependency, like the freebsd stuff.
Comment 13 Toralf Förster gentoo-dev 2014-10-09 14:42:21 UTC
(In reply to Anthony Basile from comment #12)
> Please test and reopen if this missed any dependency, like the freebsd stuff.

/me wonders, that it currently not here in the tree, usually the sync to mirrors shouldn't take longer than an hour, or ?
Comment 14 Anthony Basile gentoo-dev 2014-10-09 17:35:25 UTC
(In reply to Toralf Förster from comment #13)
> (In reply to Anthony Basile from comment #12)
> > Please test and reopen if this missed any dependency, like the freebsd stuff.
> 
> /me wonders, that it currently not here in the tree, usually the sync to
> mirrors shouldn't take longer than an hour, or ?

http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/net-misc/arm/arm-1.4.5.0-r1.ebuild?view=log