Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 523200 - sys-libs/tdb injects -fstack-protector into CFLAGS based on bad test
Summary: sys-libs/tdb injects -fstack-protector into CFLAGS based on bad test
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal minor (vote)
Assignee: Gentoo's SAMBA Team
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2014-09-19 08:01 UTC by Jeroen Roovers (RETIRED)
Modified: 2022-12-20 18:37 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
tdb-1.3.1-fstack-protector.patch (tdb-1.3.1-fstack-protector.patch,465 bytes, patch)
2014-09-19 08:01 UTC, Jeroen Roovers (RETIRED) 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeroen Roovers (RETIRED) gentoo-dev 2014-09-19 08:01:50 UTC 
Created attachment 385098 [details, diff]
tdb-1.3.1-fstack-protector.patch

Checking compiler accepts ['-fstack-protector']          : yes
Checking linker accepts ['-fstack-protector']            : yes

# echo 'int maint() { :; }' | hppa2.0-unknown-linux-gnu-gcc -E -fstack-protector - 1>/dev/null 
<stdin>:1:0: warning: -fstack-protector not supported for this target [enabled by default]
# echo $?
0

The above warning is repeated for every $CC call, which is rather annoying if harmless. Besides, tdb has no business injecting that kind of compiler flag in the first place. (waf should probably focus on not crashing 2:3 times).
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2014-09-19 08:07:05 UTC 
Actually, 1.2 does this too.