Bug 521980 – vala.eclass: sys-apps/portage-2.2.12: new repoman warnings related with dependency.unknown

• Status: RESOLVED FIXED
• Product: Portage Development

[Description Pacho Ramos 2014-09-02 15:25:19 UTC]

I think this is a regression over previous repoman versions. I am now getting this:
~/gentoo-x86/net-libs/gssdp $ repoman full

RepoMan scours the neighborhood...
>>> Creating Manifest for /home/pacho/gentoo-x86/net-libs/gssdp
  dependency.unknown            4
   net-libs/gssdp/gssdp-0.14.8-r1.ebuild: DEPEND: dev-lang/vala:0.14[vapigen], dev-lang/vala:0.16[vapigen]
   net-libs/gssdp/gssdp-0.14.8-r1.ebuild: RDEPEND: dev-lang/vala:0.14[vapigen], dev-lang/vala:0.16[vapigen]
   net-libs/gssdp/gssdp-0.14.10.ebuild: DEPEND: dev-lang/vala:0.14[vapigen], dev-lang/vala:0.16[vapigen]
   net-libs/gssdp/gssdp-0.14.10.ebuild: RDEPEND: dev-lang/vala:0.14[vapigen], dev-lang/vala:0.16[vapigen]

Note: use --include-dev (-d) to check dependencies for 'dev' profiles

RepoMan sez: "You're only giving me a partial QA payment?
              I'll take it this time, but I'm not happy."

This wasn't the case before, maybe repoman is getting confused due VALA_MIN_API_VERSION, that is used to specific the oldest version supported by the package (even if old slot/ebuilds no longer exist as it's a pretty old version)

[Comment 1 Zac Medico 2014-09-14 16:28:35 UTC]

(In reply to Pacho Ramos from comment #0)
> This wasn't the case before, maybe repoman is getting confused due
> VALA_MIN_API_VERSION, that is used to specific the oldest version supported
> by the package (even if old slot/ebuilds no longer exist as it's a pretty
> old version)

The warning is probably new for this package because the old versions of vala have been removed from the tree. However, the warning appears to be working as designed (see bug 372789).

[Comment 2 Pacho Ramos 2014-09-15 10:52:32 UTC]

@gnome, I guess we will need to simply drop VALA_MIN_API_VERSION from ebuilds when hitting this? :/ (not sure why vala.eclass prefers || () deps instead of >minimum_vala_version <maximum_vala_version

[Comment 3 Arfrever Frehtes Taifersar Arahesis 2014-09-15 11:13:23 UTC]

(In reply to Pacho Ramos from comment #2)
> @gnome, I guess we will need to simply drop VALA_MIN_API_VERSION from
> ebuilds when hitting this? :/ (not sure why vala.eclass prefers || () deps
> instead of >minimum_vala_version <maximum_vala_version

'>minimum_vala_version <maximum_vala_version' would be incorrect, because there are multiple slots of Vala.

You can change eclass to generate || ( ... ) dependencies in better way...

[Comment 4 Arfrever Frehtes Taifersar Arahesis 2014-09-15 11:35:47 UTC]

Created attachment 384776 [details, diff]
vala.eclass.patch

This patch fixes generated dependencies.

You can compare output of the following command without and with this patch:
portageq metadata / ebuild net-libs/gssdp-0.14.10::gentoo RDEPEND

[Comment 5 Gilles Dartiguelongue (RETIRED) 2014-09-23 13:21:52 UTC]

Looks good to me.

I have a question though, why not reuse default value of VALA_MIN_VERSION from the eclass ?

[Comment 6 Arfrever Frehtes Taifersar Arahesis 2014-09-24 08:55:56 UTC]

(In reply to Gilles Dartiguelongue from comment #5)
> I have a question though, why not reuse default value of VALA_MIN_VERSION
> from the eclass ?

VALA_MIN_API_VERSION=${VALA_MIN_API_VERSION:-0.18} sets VALA_MIN_API_VERSION only when it is not already set to a non-empty value.
(E.g. net-libs/gssdp-0.14.10 sets VALA_MIN_API_VERSION="0.14".)

It is possible to assign that "18" or "0.18" to a new private variable in global scope and make VALA_MIN_API_VERSION default to it.

[Comment 7 Pacho Ramos 2014-10-30 13:21:36 UTC]

+  30 Oct 2014; Pacho Ramos <[e-mail]> vala.eclass:
+  Fix repoman warnings (#521980 by Arfrever Frehtes Taifersar Arahesis)
+