Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 521766 - app-backup/spideroak-bin USE=headless - `SpiderOak --setup=-' fails because /usr/bin/SpiderOak inserts --headless
Summary: app-backup/spideroak-bin USE=headless - `SpiderOak --setup=-' fails because /...
Status: VERIFIED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Dennis Schridde
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-30 18:08 UTC by Thomas Deutschmann
Modified: 2014-10-01 17:02 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Deutschmann gentoo-dev Security 2014-08-30 18:08:04 UTC
Hi,

when you install app-backup/spideroak-bin with "headless" USE flag the ebuild will set the line

  exec "/opt/SpiderOak/lib/SpiderOak" --headless "$@"

in "/usr/bin/SpiderOak".

So every time you call SpiderOak, you will also set "--headless" parameter. This will block the required [1] "--setup=-" call required for new installations/on first usage.


Suggestion: Replace the "headless" USE flag with a "X" USE flag and don't hardcode a parameter like "--headless". So people who don't want the UI will set "-X" USE flag (like they do on other applications) and everything works. Remember, "--headless" is one option... but "--batchmode" is another one people using SpiderOak on server maybe want to use (but a hardcoded "--headless" will prevent this, too). So hardcoding "--headless" parameter is never a good idea.


[1] https://spideroak.com/faq/questions/1017/how_do_i_set_up_a_new_user_from_the_commandline


Reproducible: Always
Comment 1 Anthony Basile gentoo-dev 2014-09-03 11:19:08 UTC
(In reply to Thomas D. from comment #0)
> Hi,
> 
> when you install app-backup/spideroak-bin with "headless" USE flag the
> ebuild will set the line
> 
>   exec "/opt/SpiderOak/lib/SpiderOak" --headless "$@"
> 
> in "/usr/bin/SpiderOak".
> 
> So every time you call SpiderOak, you will also set "--headless" parameter.
> This will block the required [1] "--setup=-" call required for new
> installations/on first usage.
> 
> 
> Suggestion: Replace the "headless" USE flag with a "X" USE flag and don't
> hardcode a parameter like "--headless". So people who don't want the UI will
> set "-X" USE flag (like they do on other applications) and everything works.
> Remember, "--headless" is one option... but "--batchmode" is another one
> people using SpiderOak on server maybe want to use (but a hardcoded
> "--headless" will prevent this, too). So hardcoding "--headless" parameter
> is never a good idea.
> 
> 
> [1]
> https://spideroak.com/faq/questions/1017/
> how_do_i_set_up_a_new_user_from_the_commandline
> 
> 
> Reproducible: Always


@Thomas, care to provide a patch so its clear what you are suggesting?

@Dennis, is this change okay?
Comment 2 Anthony Basile gentoo-dev 2014-09-28 10:38:21 UTC
ping
Comment 3 Dennis Schridde 2014-09-28 14:59:20 UTC
I am fine with changing the condition from +headless to -X.

I do not care much about using SpiderOak in at -X environment, so please remove the automatic --headless, if that improves the experience for the +X users (which will probably be the majority).

I currently cannot test any of this, since I am still a few weeks away from having access to my Gentoo (+X) machine.
Comment 4 Anthony Basile gentoo-dev 2014-09-28 16:04:37 UTC
I just removed headless.  I don't use it.  And if you don't, then really there's no one testing.  We can always re-add it if there is a request.
Comment 5 Thomas Deutschmann gentoo-dev Security 2014-09-30 22:05:55 UTC
I have to re-open the issue:

The current fix solves problem, but will pull in

[...]
x11-libs/libICE
x11-libs/libXau
x11-libs/libXdmcp
x11-libs/libSM
x11-libs/libxcb
x11-libs/libX11
x11-libs/libXt
x11-libs/libXext
x11-libs/libXrender
x11-libs/libXmu
[...]

which I don't need on a server/headless system.

Please consider adding the "X" use flag like I suggested in comment #0.
For me it is the same like app-misc/mc... mc also has the "X" USE flag.
Comment 6 Anthony Basile gentoo-dev 2014-09-30 23:54:42 UTC
(In reply to Thomas D. from comment #5)
> I have to re-open the issue:
> 
> The current fix solves problem, but will pull in
> 
> [...]
> x11-libs/libICE
> x11-libs/libXau
> x11-libs/libXdmcp
> x11-libs/libSM
> x11-libs/libxcb
> x11-libs/libX11
> x11-libs/libXt
> x11-libs/libXext
> x11-libs/libXrender
> x11-libs/libXmu
> [...]
> 
> which I don't need on a server/headless system.
> 
> Please consider adding the "X" use flag like I suggested in comment #0.
> For me it is the same like app-misc/mc... mc also has the "X" USE flag.

Sorry, I interpreted your request as not caring for headless or -X, and only caring for the gui.  (If you want to get a developer to do it right the first time, send a patch!)

Please test spideroak-bin-5.1.8-r2.ebuild and see if its what you want.  Reopen if there are still any more issues.
Comment 7 Thomas Deutschmann gentoo-dev Security 2014-10-01 17:02:03 UTC
Thx! -r2 does exactly what I was looking for.