521674 – x11-misc/xsetleds-0.1.3: suspicious use of einstall

Bug 521674 - x11-misc/xsetleds-0.1.3: suspicious use of einstall

Summary: x11-misc/xsetleds-0.1.3: suspicious use of einstall

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal QA (vote)
Assignee:	John S. Skogtvedt

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	suspicious-einstall
	Show dependency tree

Reported:	2014-08-29 22:10 UTC by Michał Górny
Modified:	2014-09-03 09:03 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michał Górny archtester

2014-08-29 22:10:39 UTC

Please check whether the use of 'einstall' in this ebuild is actually
needed. From a quick glance at the Makefile, it seems to have proper
support for DESTDIR.

Therefore, if possible please replace the call to 'einstall' with proper
'default' or 'emake DESTDIR="${D}" install'. Thanks.

Comment 1 Jeroen Roovers (RETIRED) gentoo-dev

2014-09-03 09:03:40 UTC

*xsetleds-0.1.3-r1 (03 Sep 2014)

  03 Sep 2014; Jeroen Roovers <jer@gentoo.org> xsetleds-0.1.3.ebuild,
  +xsetleds-0.1.3-r1.ebuild, +files/xsetleds-0.1.3-assignment.patch,
  +files/xsetleds-0.1.3-isalpha.patch:
  einstall -> EAPI 5 default (bug #521674). Respect CC. Fix some coding issues.