Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 521564 - media-sound/rplay-3.3.2-r1: suspicious use of einstall
Summary: media-sound/rplay-3.3.2-r1: suspicious use of einstall
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal QA (vote)
Assignee: Gentoo Sound Team
URL:
Whiteboard: suspicious-einstall
Keywords:
Depends on:
Blocks: suspicious-einstall
  Show dependency tree
 
Reported: 2014-08-29 20:53 UTC by Michał Górny
Modified: 2016-08-24 19:30 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2014-08-29 20:53:58 UTC
Please check whether the use of 'einstall' in this ebuild is actually
needed. From a quick glance at the Makefile, it seems to have proper
support for DESTDIR.

Therefore, if possible please replace the call to 'einstall' with proper
'default' or 'emake DESTDIR="${D}" install'. Thanks.
Comment 1 Michael Orlitzky gentoo-dev 2016-08-24 19:30:13 UTC
Turns out it was needed in this case.


commit 1c8ca3692822fe070a8aa920fd06d7398c2b2364
Author: Michael Orlitzky <mjo@gentoo.org>
Date:   Wed Aug 24 15:25:58 2016 -0400

    media-sound/rplay: new revision with EAPI=6.

    The original purpose of this new revision was to fix the use of
    einstall reported in bug 521564. However, einstall proved necessary,
    so along with the update to EAPI=6 -- where einstall is banned -- I
    inlined its behavior.

    The multilib and eutils eclasses, now unused, were dropped. The latest
    debian patchset was also included.

    Package-Manager: portage-2.2.28